Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leader cache everywhere #1594

Merged
merged 6 commits into from Jul 25, 2017
Merged

Leader cache everywhere #1594

merged 6 commits into from Jul 25, 2017

Conversation

@baconmania
Copy link
Contributor

@baconmania baconmania commented Jul 14, 2017

No description provided.

Copy link
Member

@ssalinas ssalinas left a comment

Since the leader cache will persist across runs of the pollers and calls of the offers methods, we should probably keep the code cleaner by @Injecting it instead of passing it around as an argument. Other than that looks good 👍

@baconmania baconmania changed the title (WIP) Leader cache everywhere Leader cache everywhere Jul 17, 2017
@ssalinas ssalinas merged commit aa6185d into master Jul 25, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ssalinas ssalinas deleted the leader-cache-everywhere branch Jul 25, 2017
@baconmania baconmania added this to the 0.17.0 milestone Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.