Leader cache everywhere - #1594
Merged
Merged
Conversation
ssalinas
suggested changes
Jul 17, 2017
ssalinas
left a comment
ssalinas
left a comment
Contributor
There was a problem hiding this comment.
Since the leader cache will persist across runs of the pollers and calls of the offers methods, we should probably keep the code cleaner by @Injecting it instead of passing it around as an argument. Other than that looks good 👍
ssalinas
approved these changes
Jul 24, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.