New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also relocate guava-retrying in SingularityClient #1597

Merged
merged 1 commit into from Jul 24, 2017

Conversation

Projects
None yet
3 participants
@ssalinas
Member

ssalinas commented Jul 19, 2017

The interactions of unshaded retryer with shaded guava were causing issues. Shading retryer as well in SingularityClient

/cc @stevegutz

@ssalinas ssalinas merged commit 9b5b9c6 into master Jul 24, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the shaded_retryer branch Jul 24, 2017

@stevegutz

This comment has been minimized.

Show comment
Hide comment
@stevegutz

stevegutz Jul 24, 2017

Contributor

I didn't get an email when you tagged me initially for some reason. LGTM

Contributor

stevegutz commented Jul 24, 2017

I didn't get an email when you tagged me initially for some reason. LGTM

@baconmania baconmania added this to the 0.17.0 milestone Sep 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment