Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logrotateFrequency field in new deploy form #1599

Merged
merged 3 commits into from Oct 4, 2017
Merged

Add logrotateFrequency field in new deploy form #1599

merged 3 commits into from Oct 4, 2017

Conversation

@ssalinas
Copy link
Member

@ssalinas ssalinas commented Jul 21, 2017

/fixes #1431

/fyi @kwm4385 @petrovicboban

ssalinas added 2 commits Jul 21, 2017
@ssalinas ssalinas added the hs_staging label Jul 24, 2017
@kwm4385 kwm4385 self-requested a review Sep 18, 2017
@kwm4385 kwm4385 self-assigned this Sep 18, 2017
@@ -769,6 +770,22 @@ class NewDeployForm extends Component {
couldHaveFeedback={true}
/>
);
const logrotateFrequency = (
<SelectFormGroup
id={"logrotate-frequency"}

This comment has been minimized.

@tpetr

tpetr Sep 18, 2017
Member

any specific reason for { } for this field?

@kwm4385 kwm4385 added the hs_stable label Sep 20, 2017
@kwm4385
Copy link
Contributor

@kwm4385 kwm4385 commented Sep 20, 2017

@tpetr This is in all environments now and working as intended.

@ssalinas ssalinas merged commit 668ac77 into master Oct 4, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@hs-jenkins-bot

This comment has been minimized.

Copy link
Contributor

@hs-jenkins-bot hs-jenkins-bot commented on 38ed65f Oct 4, 2017

@ssalinas you pushed this commit but Enron could not associate a GitHub User for this commit, making this commit un-signable.
The Author Email was ssalinas@hubspot.com
The Committer Email was ssalinas@hubspot.com This is usually due to an invalid local git configuration that prevents us from mapping these commits to a GitHub user account.Please make sure your git config has your work email (@hubspot.com) address for the user.email field. See our documentation on fixing this error here

@ssalinas ssalinas deleted the logrotate_freq branch Oct 4, 2017
@hs-jenkins-bot

This comment has been minimized.

Copy link
Contributor

@hs-jenkins-bot hs-jenkins-bot commented on b843782 Oct 4, 2017

@ssalinas you pushed this commit but Enron could not associate a GitHub User for this commit, making this commit un-signable.
The Author Email was ssalinas@hubspot.com
The Committer Email was ssalinas@hubspot.com This is usually due to an invalid local git configuration that prevents us from mapping these commits to a GitHub user account.Please make sure your git config has your work email (@hubspot.com) address for the user.email field. See our documentation on fixing this error here

@hs-jenkins-bot

This comment has been minimized.

Copy link
Contributor

@hs-jenkins-bot hs-jenkins-bot commented on f580e2e Oct 4, 2017

@ssalinas you pushed this commit but Enron could not associate a GitHub User for this commit, making this commit un-signable.
The Author Email was kmoses@hubspot.com
The Committer Email was kmoses@hubspot.com This is usually due to an invalid local git configuration that prevents us from mapping these commits to a GitHub user account.Please make sure your git config has your work email (@hubspot.com) address for the user.email field. See our documentation on fixing this error here

@ssalinas ssalinas added this to the 0.18.0 milestone Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.