Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report disk usage #1600

Merged
merged 26 commits into from Jan 17, 2018
Merged

Report disk usage #1600

merged 26 commits into from Jan 17, 2018

Conversation

@baconmania
Copy link
Contributor

@baconmania baconmania commented Jul 21, 2017

No description provided.

@@ -113,6 +113,11 @@ public SingularityTask buildTask(SingularityOfferHolder offerHolder, List<Resour

if (desiredTaskResources.getDiskMb() > 0) {
bldr.addResources(MesosUtils.getDiskResource(desiredTaskResources.getDiskMb(), requiredRole));
} else if (MesosUtils.getDisk(offerHolder.getCurrentResources(), Optional.absent()) >= 1.0) {
// If this offer contains 1MB of disk resources, claim it to enable disk usage reporting.
// This is just a temporary hack to enable disk usage reporting where we can, not an actual way to match task disk requirements to offers.
Copy link
Member

@ssalinas ssalinas Oct 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we roll this out anywhere else, it would probably be better to set something more like a configurable default disk (similar to the default mem/cpus). If someone were to have disk isolation enforced by default, this would be very problematic

Loading

@ssalinas ssalinas added this to the 0.18.0 milestone Oct 11, 2017
@ssalinas ssalinas removed this from the 0.18.0 milestone Nov 3, 2017
@ssalinas ssalinas added this to the 0.19.0 milestone Nov 3, 2017
@ssalinas ssalinas changed the title (WIP) Report disk usage Report disk usage Jan 17, 2018
@ssalinas
Copy link
Member

@ssalinas ssalinas commented Jan 17, 2018

🚢

Loading

@ssalinas ssalinas merged commit 0612256 into master Jan 17, 2018
2 checks passed
Loading
@ssalinas ssalinas deleted the report-disk-usage branch Jan 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants