Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report disk usage #1600

Merged
merged 26 commits into from Jan 17, 2018

Conversation

Projects
None yet
2 participants
@baconmania
Copy link
Contributor

commented Jul 21, 2017

No description provided.

@@ -113,6 +113,11 @@ public SingularityTask buildTask(SingularityOfferHolder offerHolder, List<Resour

if (desiredTaskResources.getDiskMb() > 0) {
bldr.addResources(MesosUtils.getDiskResource(desiredTaskResources.getDiskMb(), requiredRole));
} else if (MesosUtils.getDisk(offerHolder.getCurrentResources(), Optional.absent()) >= 1.0) {
// If this offer contains 1MB of disk resources, claim it to enable disk usage reporting.
// This is just a temporary hack to enable disk usage reporting where we can, not an actual way to match task disk requirements to offers.

This comment has been minimized.

Copy link
@ssalinas

ssalinas Oct 10, 2017

Member

Before we roll this out anywhere else, it would probably be better to set something more like a configurable default disk (similar to the default mem/cpus). If someone were to have disk isolation enforced by default, this would be very problematic

@ssalinas ssalinas added this to the 0.18.0 milestone Oct 11, 2017

@ssalinas ssalinas modified the milestones: 0.18.0, 0.19.0 Nov 3, 2017

baconmania added some commits Dec 8, 2017

@ssalinas ssalinas changed the title (WIP) Report disk usage Report disk usage Jan 17, 2018

@ssalinas

This comment has been minimized.

Copy link
Member

commented Jan 17, 2018

🚢

@ssalinas ssalinas merged commit 0612256 into master Jan 17, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the report-disk-usage branch Jan 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.