Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change to allow . in deploy id #1605

Merged
merged 1 commit into from Aug 4, 2017
Merged

Conversation

@whitedr
Copy link
Contributor

@whitedr whitedr commented Aug 4, 2017

No description provided.

Dave White
@ssalinas
Copy link
Member

@ssalinas ssalinas commented Aug 4, 2017

related to conversation from #1406 (comment) and #1407

@ssalinas ssalinas added the hs_staging label Aug 4, 2017
@ssalinas
Copy link
Member

@ssalinas ssalinas commented Aug 4, 2017

Looked fine testing locally, running it in our staging/qa/stable environments and I'll get this merged for a quick 0.16.2 for you

@ssalinas ssalinas added this to the 0.16.2 milestone Aug 4, 2017
@whitedr
Copy link
Contributor Author

@whitedr whitedr commented Aug 4, 2017

That's great. Thanks for the quick turnaround on this!

@ssalinas ssalinas added hs_qa labels Aug 4, 2017
@ssalinas ssalinas merged commit 8ba7ec0 into HubSpot:master Aug 4, 2017
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@baconmania baconmania removed this from the 0.17.0 milestone Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.