New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change to allow . in deploy id #1605

Merged
merged 1 commit into from Aug 4, 2017

Conversation

Projects
None yet
3 participants
@whitedr
Contributor

whitedr commented Aug 4, 2017

No description provided.

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Aug 4, 2017

Member

related to conversation from #1406 (comment) and #1407

Member

ssalinas commented Aug 4, 2017

related to conversation from #1406 (comment) and #1407

@ssalinas ssalinas added the hs_staging label Aug 4, 2017

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Aug 4, 2017

Member

Looked fine testing locally, running it in our staging/qa/stable environments and I'll get this merged for a quick 0.16.2 for you

Member

ssalinas commented Aug 4, 2017

Looked fine testing locally, running it in our staging/qa/stable environments and I'll get this merged for a quick 0.16.2 for you

@ssalinas ssalinas added this to the 0.16.2 milestone Aug 4, 2017

@whitedr

This comment has been minimized.

Show comment
Hide comment
@whitedr

whitedr Aug 4, 2017

Contributor

That's great. Thanks for the quick turnaround on this!

Contributor

whitedr commented Aug 4, 2017

That's great. Thanks for the quick turnaround on this!

@ssalinas ssalinas merged commit 8ba7ec0 into HubSpot:master Aug 4, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@baconmania baconmania removed this from the 0.17.0 milestone Sep 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment