Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HostAndPort#getHostText instead of HostAndPort#getHost #1609

Merged
merged 2 commits into from Dec 7, 2017

Conversation

Projects
None yet
2 participants
@stevegutz
Copy link
Contributor

commented Aug 14, 2017

HostAndPost#getHost replaced HostAndPort#getHostText in Guava 20 and HostAndPort#getHostText was removed in Guava 22. This PR should have no semantic effect on your code. Java doc

I had to upgrade to Guava 20.0 to get the new functionality and if I go to 21 we might have trouble because the version of curator this is on is not compatible with that version. This codepath should never be hit outside of SingularityService and EmbedSingularityExample, so don't rush to merge this if you're worried about the version change.

@ssalinas @baconmania @darcatron

@ssalinas ssalinas added this to the 0.18.0 milestone Oct 11, 2017

@ssalinas ssalinas added the hs_staging label Oct 12, 2017

@ssalinas ssalinas modified the milestones: 0.18.0, 0.19.0 Nov 3, 2017

@ssalinas ssalinas added the hs_qa label Nov 30, 2017

@ssalinas

This comment has been minimized.

Copy link
Member

commented Dec 7, 2017

🚢

@ssalinas ssalinas added the hs_stable label Dec 7, 2017

@stevegutz

This comment has been minimized.

Copy link
Contributor Author

commented Dec 7, 2017

🎄

@ssalinas ssalinas merged commit 48d80f4 into master Dec 7, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the rm-getHostText branch Dec 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.