Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visibility around getChildren() calls. #1615

Merged
merged 2 commits into from Sep 20, 2017

Conversation

@baconmania
Copy link
Contributor

@baconmania baconmania commented Sep 5, 2017

No description provided.

@baconmania baconmania requested a review from tpetr Sep 18, 2017
@@ -123,6 +123,7 @@ protected boolean exists(String path) {
}

protected List<String> getChildren(String root) {
LOG.debug("Preparing to call getChildren() on {}", root);

This comment has been minimized.

@tpetr

tpetr Sep 18, 2017
Member

it this information still useful for us? If yes: I'd suggest making it trace() instead (it's pretty verbose). If not: please delete.

@tpetr
tpetr approved these changes Sep 20, 2017
@baconmania baconmania merged commit e1de8b5 into master Sep 20, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@baconmania baconmania deleted the add-visibility-to-getChildren-calls branch Sep 20, 2017
@baconmania baconmania modified the milestones: 0.16.3, 0.17.0 Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.