New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

look at new scale request before opting to old request #1621

Merged
merged 1 commit into from Oct 4, 2017

Conversation

Projects
None yet
4 participants
@darcatron
Contributor

darcatron commented Sep 22, 2017

if the scaleRequest had an optional value, that should be considered first. If it's absent, we can consider the previous request

@darcatron darcatron requested a review from baconmania Sep 22, 2017

@darcatron darcatron added the hs_qa label Oct 2, 2017

@darcatron darcatron added the hs_stable label Oct 2, 2017

@darcatron darcatron merged commit 148f4b8 into master Oct 4, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@hs-jenkins-bot

This comment has been minimized.

Show comment
Hide comment
@hs-jenkins-bot

hs-jenkins-bot Oct 4, 2017

Contributor

@darcatron you pushed this commit but Enron could not associate a GitHub User for this commit, making this commit un-signable.
The Author Email was mvimalesvaran@hubspot.com
The Committer Email was mvimalesvaran@hubspot.com This is usually due to an invalid local git configuration that prevents us from mapping these commits to a GitHub user account.Please make sure your git config has your work email (@hubspot.com) address for the user.email field. See our documentation on fixing this error here

Contributor

hs-jenkins-bot commented on 19d3c10 Oct 4, 2017

@darcatron you pushed this commit but Enron could not associate a GitHub User for this commit, making this commit un-signable.
The Author Email was mvimalesvaran@hubspot.com
The Committer Email was mvimalesvaran@hubspot.com This is usually due to an invalid local git configuration that prevents us from mapping these commits to a GitHub user account.Please make sure your git config has your work email (@hubspot.com) address for the user.email field. See our documentation on fixing this error here

@darcatron darcatron deleted the scale-fix branch Oct 4, 2017

@ssalinas ssalinas added this to the 0.18.0 milestone Oct 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment