Expose instance counts for singularity requests #1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also fyi @kwm4385 , this would give us information for the request detail page so we could display which of the active tasks are currently healthy. It would be a single endpoint that could replace the pending/cleaning/active calls |
|
worked fine on my local testing against qa 🚢 |
baconmania
approved these changes
Oct 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an endpoint that exposes the counts of tasks that are active/pending/healthy/unhealthy. Debating changing it to be the list of task ids rather than just the counts so we could then use it to possibly display which tasks are healthy in the ui.
/cc @darcatron