New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve instance id order when scaling down #1628

Merged
merged 5 commits into from Oct 13, 2017

Conversation

Projects
None yet
2 participants
@ssalinas
Member

ssalinas commented Oct 6, 2017

Example situation:

  • Tasks with instance number 1,2,4,5 are active and there is a single pending task
  • request is scaled down to 4
  • pending task is deleted and no tasks are cleaned, remaining instances are 1,2,4,5

This PR updates the scheduler to preserve the instance numbers in order since a number of systems depend on them being contiguous. This causes slightly more task churn in a few cases in return for consistency. If the task churn is an issue, we can always put it behind a configuration flag.

tests added, haven't added the config flag just yet

@darcatron

@ssalinas ssalinas added the hs_staging label Oct 10, 2017

@ssalinas ssalinas added this to the 0.18.0 milestone Oct 11, 2017

@ssalinas ssalinas added the hs_qa label Oct 11, 2017

@darcatron

This comment has been minimized.

Show comment
Hide comment
@darcatron

darcatron Oct 12, 2017

Contributor

🚢

Contributor

darcatron commented Oct 12, 2017

🚢

@ssalinas ssalinas added the hs_stable label Oct 12, 2017

@ssalinas ssalinas merged commit 9688f7b into master Oct 13, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the preserve_ids branch Oct 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment