Add shell commands to the client#1629
Merged
Merged
Conversation
kwm4385
reviewed
Oct 10, 2017
| return post(requestUri, "start shell command", Optional.of(shellCommand), Optional.of(SingularityTaskShellCommandRequest.class)).orNull(); | ||
| } | ||
|
|
||
| public Collection<SingularityTaskShellCommandHistory> getShellCommandHisotry(String taskId) { |
Contributor
There was a problem hiding this comment.
getShellCommandHisotry -> getShellCommandHistory
matush-v
reviewed
Oct 12, 2017
| public Collection<SingularityTaskShellCommandUpdate> getShellCommandUpdates(SingularityTaskShellCommandRequest shellCommandRequest) { | ||
| final Function<String, String> requestUri = (host) -> String.format(SHELL_COMMAND_UPDATES_FORMAT, getApiBase(host), shellCommandRequest.getTaskId(), shellCommandRequest.getShellCommand().getName(), shellCommandRequest.getTimestamp()); | ||
|
|
||
| return getCollection(requestUri, "get shell command history", SHELL_COMMAND_UPDATES); |
Contributor
There was a problem hiding this comment.
maybe get shell command update history instead just so it's differentiated a bit?
Contributor
Author
There was a problem hiding this comment.
getCollection is the generic implementation to get a collection of objects, it's a private method. The public one is already named getShellCommandUpdates
Contributor
Author
There was a problem hiding this comment.
oh, you meant the string there, :derp: 👍
Contributor
|
🚢 🚢 🚢 ⚓️ |
baconmania
previously approved these changes
Oct 12, 2017
Contributor
|
🚢 |
kwm4385
approved these changes
Oct 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also adds endpoints to get more individual shell command data