Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shell commands to the client #1629

Merged
merged 4 commits into from Oct 12, 2017
Merged

Add shell commands to the client #1629

merged 4 commits into from Oct 12, 2017

Conversation

@ssalinas
Copy link
Member

@ssalinas ssalinas commented Oct 10, 2017

also adds endpoints to get more individual shell command data

return post(requestUri, "start shell command", Optional.of(shellCommand), Optional.of(SingularityTaskShellCommandRequest.class)).orNull();
}

public Collection<SingularityTaskShellCommandHistory> getShellCommandHisotry(String taskId) {

This comment has been minimized.

@kwm4385

kwm4385 Oct 10, 2017
Contributor

getShellCommandHisotry -> getShellCommandHistory

This comment has been minimized.

@ssalinas

ssalinas Oct 11, 2017
Author Member

thanks! fixed

@ssalinas ssalinas added the hs_staging label Oct 11, 2017
@ssalinas ssalinas added this to the 0.18.0 milestone Oct 11, 2017
@ssalinas ssalinas added the hs_qa label Oct 11, 2017
public Collection<SingularityTaskShellCommandUpdate> getShellCommandUpdates(SingularityTaskShellCommandRequest shellCommandRequest) {
final Function<String, String> requestUri = (host) -> String.format(SHELL_COMMAND_UPDATES_FORMAT, getApiBase(host), shellCommandRequest.getTaskId(), shellCommandRequest.getShellCommand().getName(), shellCommandRequest.getTimestamp());

return getCollection(requestUri, "get shell command history", SHELL_COMMAND_UPDATES);

This comment has been minimized.

@darcatron

darcatron Oct 12, 2017
Contributor

maybe get shell command update history instead just so it's differentiated a bit?

This comment has been minimized.

@ssalinas

ssalinas Oct 12, 2017
Author Member

getCollection is the generic implementation to get a collection of objects, it's a private method. The public one is already named getShellCommandUpdates

This comment has been minimized.

@ssalinas

ssalinas Oct 12, 2017
Author Member

oh, you meant the string there, :derp: 👍

@darcatron
Copy link
Contributor

@darcatron darcatron commented Oct 12, 2017

🚢 🚢 🚢 ⚓️

@ssalinas ssalinas added the hs_stable label Oct 12, 2017
@darcatron
Copy link
Contributor

@darcatron darcatron commented Oct 12, 2017

🚢

@ssalinas ssalinas merged commit 13b8c8e into master Oct 12, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
@ssalinas ssalinas deleted the shell_commands_client branch Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.