Mesos backpressure #1630
Merged
Mesos backpressure #1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baconmania
reviewed
Oct 12, 2017
| String message = String.format("Overflow of event buffer (%s), singularity could not keep up!", scheduler.getEventBufferSize()); | ||
| scheduler.onUncaughtException(new EventBufferOverflowException(message)); | ||
| }, | ||
| BackpressureOverflow.ON_OVERFLOW_ERROR); |
There was a problem hiding this comment.
So just to confirm, if the set of pending events overflows the max buffer size, we get a top-level exception and abort?
There was a problem hiding this comment.
yes, it'll cause an abort if the buffer overflows. I felt that was more in line with our idea of keeping state consistent than dropping things. There is an alternative for using an unbounded buffer, but I figured it'd be better to abort with an exception than to oom
baconmania
approved these changes
Oct 12, 2017
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diff will look nicer once the other mesos_1 PR is merged. Relevant commit is d15af0f
Moves the backpressure to the mesos client itself now that 0.2.0 of mesos-rxjava allows us to set backpressure behaviors. Also doubles the default event buffer size to handle large influxes of status updates from reconciliation
/cc @darcatron @baconmania