New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesos backpressure #1630

Merged
merged 2 commits into from Oct 12, 2017

Conversation

Projects
None yet
2 participants
@ssalinas
Member

ssalinas commented Oct 11, 2017

Diff will look nicer once the other mesos_1 PR is merged. Relevant commit is d15af0f

Moves the backpressure to the mesos client itself now that 0.2.0 of mesos-rxjava allows us to set backpressure behaviors. Also doubles the default event buffer size to handle large influxes of status updates from reconciliation

/cc @darcatron @baconmania

String message = String.format("Overflow of event buffer (%s), singularity could not keep up!", scheduler.getEventBufferSize());
scheduler.onUncaughtException(new EventBufferOverflowException(message));
},
BackpressureOverflow.ON_OVERFLOW_ERROR);

This comment has been minimized.

@baconmania

baconmania Oct 12, 2017

Contributor

So just to confirm, if the set of pending events overflows the max buffer size, we get a top-level exception and abort?

@baconmania

baconmania Oct 12, 2017

Contributor

So just to confirm, if the set of pending events overflows the max buffer size, we get a top-level exception and abort?

This comment has been minimized.

@ssalinas

ssalinas Oct 12, 2017

Member

yes, it'll cause an abort if the buffer overflows. I felt that was more in line with our idea of keeping state consistent than dropping things. There is an alternative for using an unbounded buffer, but I figured it'd be better to abort with an exception than to oom

@ssalinas

ssalinas Oct 12, 2017

Member

yes, it'll cause an abort if the buffer overflows. I felt that was more in line with our idea of keeping state consistent than dropping things. There is an alternative for using an unbounded buffer, but I figured it'd be better to abort with an exception than to oom

This comment has been minimized.

@baconmania

baconmania Oct 12, 2017

Contributor

Agreed.

@baconmania

baconmania Oct 12, 2017

Contributor

Agreed.

@baconmania

This comment has been minimized.

Show comment
Hide comment
@baconmania

baconmania Oct 12, 2017

Contributor

🚢

Contributor

baconmania commented Oct 12, 2017

🚢

@ssalinas ssalinas added the hs_stable label Oct 12, 2017

@ssalinas ssalinas merged commit 38f4042 into master Oct 12, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the mesos_backpressure branch Oct 12, 2017

@ssalinas ssalinas added this to the 0.18.0 milestone Nov 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment