New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New dashboard in Singularity + other UI improvements #1636
Conversation
On a good suggestion from @baconmania , going to not use the specific endpoints, but instead refactor the current requests/etc ones a bit to better fit the needs of the ui (behind filters/params/etc) |
@kwm4385 I put together a quick 15-minute version of a new dashboard, mostly so that the logic is all written out for you to see the new data the backend is providing for you (and because I got angry at auth and wanted to take a break from it...). Ordering by default is based on requests that have most recently had something interesting happen, and the list of requests is filtered (by the backend) to ones that are relevant to the user.
As an additional note, the tasks piece is a bit more of an expensive api call when done across a large number of requests, so it won't be feasible to use for the normal requests page. Using it here for dashboard since the list by nature is slimmed down. |
Some thoughts on the current iteration:
|
Just one final thought here
cc @ssalinas |
Yeah, I can add two more. They are actually separate concepts, not separate states on the backend which is why i didn't at first (i.e. you'll never see a pending/cleaning in the same list as active/paused/cooldown) |
Extra icons added now @kwm4385 |
I think this is in a good state to move forward to stable. We'll keep an ear to the ground for user feedback and make further tweaks based on that. |
@kwm4385 , this is the WIP PR we can build upon for creating user and group based views within Singularity. I have created a separate dropwizard resource with new pojos that will aggregate all data the UI needs for certain pages in a single call. We may need to do some extra bits around things like history paging and such, but we can at least get the basic details of active elements all in a single call, with some extra details like instance health included.
My goal with this would be to replace the current dashboard page with something smarter, generally eliminating the need for the requests page, as well as adding some needed details like instance health in the task detail page.
We should also try to eliminate some extraneous calls we tend to make on a number of pages like:
Feel free to comment on anything you might specifically want the backend to serve up all together. I'll add more detail here as I flush things out