Shade protobuf for SingularityClient/SingularityBase #1642
Conversation
|
Looks reasonable to me. For things like protobuf its also common to add the version to the package name, eg Is shading just the client is enough? It doesn't leak into models or anything? |
|
Good point, might need it in SingularityBase as well. I can add that |
ssalinas
changed the title
ssalinas
force-pushed
the
shade_protobuf
branch
from
2e1cdf6 to
8bc7f55
Compare
ssalinas
changed the title
|
Ended up being easier to shade mesos completely here |
|
🚢 |
|
There are a few more steps we need to take to solve the protos issues. This is a step in the right direction, so going to merge this and open an additional PR rather than continuing to work off this branch |
| <relocations> | ||
| <relocation> | ||
| <pattern>org.apache.mesos</pattern> | ||
| <shadedPattern>com.hubspot.singularity.shaded.org.apache.mesos.oneonetwo</shadedPattern> |
There was a problem hiding this comment.
I don't think think that this will solve your problem. The issue isn't using an unshaded mesos, it's that mesos is using an unshaded protobuf that conflicts with what we want. So you want to rewrite the protobuf classes inside mesos, not mesos itself.
Systems running protobuf 2.5 were having issues since mesos 1.x pulls in protobuf 2.6.1
@stevegutz