Skip to content

Shade protobuf for SingularityClient/SingularityBase#1642

Merged
ssalinas merged 3 commits into
masterfrom
shade_protobuf
Nov 6, 2017
Merged

Shade protobuf for SingularityClient/SingularityBase#1642
ssalinas merged 3 commits into
masterfrom
shade_protobuf

Conversation

@ssalinas

@ssalinas ssalinas commented Nov 2, 2017

Copy link
Copy Markdown
Contributor

Systems running protobuf 2.5 were having issues since mesos 1.x pulls in protobuf 2.6.1

@stevegutz

@stevie400

Copy link
Copy Markdown
Contributor

Looks reasonable to me. For things like protobuf its also common to add the version to the package name, eg com.hubspot.singularity.shaded.com.google.protobuf.twosixone or whatever.

Is shading just the client is enough? It doesn't leak into models or anything?

@ssalinas

ssalinas commented Nov 2, 2017

Copy link
Copy Markdown
Contributor Author

Good point, might need it in SingularityBase as well. I can add that

@ssalinas ssalinas added this to the 0.19.0 milestone Nov 3, 2017
@ssalinas ssalinas changed the title Shade protobuf for SingularityClient Shade mesos for SingularityClient/SingularityBase Nov 3, 2017
@ssalinas ssalinas changed the title Shade mesos for SingularityClient/SingularityBase Shade protobuf for SingularityClient/SingularityBase Nov 3, 2017
@ssalinas ssalinas added the hs_qa label Nov 3, 2017
@ssalinas

ssalinas commented Nov 3, 2017

Copy link
Copy Markdown
Contributor Author

Ended up being easier to shade mesos completely here

@baconmania

Copy link
Copy Markdown
Contributor

🚢

@ssalinas ssalinas modified the milestones: 0.19.0, 0.18.0 Nov 3, 2017
@ssalinas

ssalinas commented Nov 6, 2017

Copy link
Copy Markdown
Contributor Author

There are a few more steps we need to take to solve the protos issues. This is a step in the right direction, so going to merge this and open an additional PR rather than continuing to work off this branch

@ssalinas
ssalinas merged commit 7d24856 into master Nov 6, 2017
@ssalinas
ssalinas deleted the shade_protobuf branch November 6, 2017 14:11
Comment thread SingularityBase/pom.xml
<relocations>
<relocation>
<pattern>org.apache.mesos</pattern>
<shadedPattern>com.hubspot.singularity.shaded.org.apache.mesos.oneonetwo</shadedPattern>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think think that this will solve your problem. The issue isn't using an unshaded mesos, it's that mesos is using an unshaded protobuf that conflicts with what we want. So you want to rewrite the protobuf classes inside mesos, not mesos itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants