Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 folders #1647

Merged
merged 4 commits into from Nov 15, 2017
Merged

S3 folders #1647

merged 4 commits into from Nov 15, 2017

Conversation

kwm4385
Copy link
Contributor

@kwm4385 kwm4385 commented Nov 7, 2017

Groups S3 files in the UI into folders based on the top level directory of their S3 key (service, access, thread_dumps, etc.).
kapture 2017-11-07 at 14 21 11

@kwm4385 kwm4385 added the hs_qa label Nov 7, 2017
Copy link

@andyhuang91 andyhuang91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code seems okay. In terms of the design,

  1. It would be good to display the selected viewing group so that users will always know what they are looking at.

  2. Is there always going to be only one level of directories?

  3. Should we do something to make this view more similar to the files section?

this.state = {
viewingGroup: null
};
this.getFileType = this.getFileType.bind(this);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't need a bind since it never uses this. Sometimes I'll try to separate out pure functions / utility methods from class methods in my JS code.

@kwm4385
Copy link
Contributor Author

kwm4385 commented Nov 7, 2017

Talked to @andyhuang91 irl, this should be ready to ship @ssalinas

@ssalinas
Copy link
Member

ssalinas commented Nov 7, 2017

🚢

@ssalinas ssalinas added this to the 0.18.0 milestone Nov 15, 2017
@ssalinas ssalinas merged commit 7810daf into master Nov 15, 2017
@ssalinas ssalinas deleted the s3-folders branch November 15, 2017 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants