S3 folders - #1647
Merged
Merged
Conversation
andyhuang91
reviewed
Nov 7, 2017
andyhuang91
left a comment
andyhuang91
left a comment
There was a problem hiding this comment.
The code seems okay. In terms of the design,
-
It would be good to display the selected viewing group so that users will always know what they are looking at.
-
Is there always going to be only one level of directories?
-
Should we do something to make this view more similar to the files section?
| this.state = { | ||
| viewingGroup: null | ||
| }; | ||
| this.getFileType = this.getFileType.bind(this); |
There was a problem hiding this comment.
This doesn't need a bind since it never uses this. Sometimes I'll try to separate out pure functions / utility methods from class methods in my JS code.
Contributor
Author
|
Talked to @andyhuang91 irl, this should be ready to ship @ssalinas |
Contributor
|
🚢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Groups S3 files in the UI into folders based on the top level directory of their S3 key (
service,access,thread_dumps, etc.).