Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't error when ArtifactManager copies duplicate files #1649

Merged
merged 2 commits into from Nov 17, 2017

Conversation

pschoenfelder
Copy link
Contributor

No description provided.

Files.copy(source, destinationPath);
} catch (FileAlreadyExistsException e) {
if (!calculateMd5sum(source).equals(calculateMd5sum(destinationPath))) {
Throwables.propagate(e);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that Throwables#propagate is deprecated (see https://github.com/google/guava/wiki/Why-we-deprecated-Throwables.propagate)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we have an open TODO to replace a number of guava things like propagate/Optional in Singularity. If we replace propagate usage @pschoenfelder can we do it throughout the whole class at least? Would be good to start cleaning these up as we go along

@ssalinas ssalinas added this to the 0.19.0 milestone Nov 15, 2017
@ssalinas
Copy link
Member

🚢

@ssalinas ssalinas modified the milestones: 0.19.0, 0.18.0 Nov 17, 2017
@ssalinas ssalinas merged commit 982cca5 into master Nov 17, 2017
@ssalinas ssalinas deleted the s3_dupe_file_dl branch November 17, 2017 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants