Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't error when ArtifactManager copies duplicate files #1649

Merged
merged 2 commits into from Nov 17, 2017
Merged

Conversation

@pschoenfelder
Copy link
Contributor

@pschoenfelder pschoenfelder commented Nov 13, 2017

No description provided.

Files.copy(source, destinationPath);
} catch (FileAlreadyExistsException e) {
if (!calculateMd5sum(source).equals(calculateMd5sum(destinationPath))) {
Throwables.propagate(e);

This comment has been minimized.

This comment has been minimized.

@ssalinas

ssalinas Nov 13, 2017
Member

Yeah, we have an open TODO to replace a number of guava things like propagate/Optional in Singularity. If we replace propagate usage @pschoenfelder can we do it throughout the whole class at least? Would be good to start cleaning these up as we go along

@ssalinas ssalinas added this to the 0.19.0 milestone Nov 15, 2017
@ssalinas
Copy link
Member

@ssalinas ssalinas commented Nov 17, 2017

🚢

@ssalinas ssalinas modified the milestones: 0.19.0, 0.18.0 Nov 17, 2017
@ssalinas ssalinas merged commit 982cca5 into master Nov 17, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ssalinas ssalinas deleted the s3_dupe_file_dl branch Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.