Don't error when ArtifactManager copies duplicate files #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szabowexler
reviewed
Nov 13, 2017
| Files.copy(source, destinationPath); | ||
| } catch (FileAlreadyExistsException e) { | ||
| if (!calculateMd5sum(source).equals(calculateMd5sum(destinationPath))) { | ||
| Throwables.propagate(e); |
There was a problem hiding this comment.
Note that Throwables#propagate is deprecated (see https://github.com/google/guava/wiki/Why-we-deprecated-Throwables.propagate)
There was a problem hiding this comment.
Yeah, we have an open TODO to replace a number of guava things like propagate/Optional in Singularity. If we replace propagate usage @pschoenfelder can we do it throughout the whole class at least? Would be good to start cleaning these up as we go along
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.