-
Notifications
You must be signed in to change notification settings - Fork 187
Ability to specify quick links for requests #1654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @kwm4385 |
SingularityUI/app/utils.es6
Outdated
} | ||
}); | ||
} catch (err) { | ||
return undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason you're returning undefined
rather than null
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no particular reason. Is there a preference/reasoning for one over the other?
🚢 |
🚢 |
This adds a way that we can set custom links to other places in the infrastructure from the request detail page. The links can be templated using formats like:
http://example.com?person={{request.owners.0}}
. The links can be specified per request type as well. I also put a top level key of "request" in the config in case we later decide to add some for tasks or something else more specific.Links, if present, will appear in a small dropdown button in the request action buttons section: