Ability to specify quick links for requests #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @kwm4385 |
kwm4385
reviewed
Nov 17, 2017
SingularityUI/app/utils.es6
Outdated
| } | ||
| }); | ||
| } catch (err) { | ||
| return undefined; |
There was a problem hiding this comment.
Is there a reason you're returning undefined rather than null?
There was a problem hiding this comment.
no particular reason. Is there a preference/reasoning for one over the other?
|
🚢 |
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a way that we can set custom links to other places in the infrastructure from the request detail page. The links can be templated using formats like:
http://example.com?person={{request.owners.0}}. The links can be specified per request type as well. I also put a top level key of "request" in the config in case we later decide to add some for tasks or something else more specific.Links, if present, will appear in a small dropdown button in the request action buttons section: