New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to specify quick links for requests #1654

Merged
merged 8 commits into from Dec 5, 2017

Conversation

Projects
None yet
3 participants
@ssalinas
Member

ssalinas commented Nov 17, 2017

This adds a way that we can set custom links to other places in the infrastructure from the request detail page. The links can be templated using formats like: http://example.com?person={{request.owners.0}}. The links can be specified per request type as well. I also put a top level key of "request" in the config in case we later decide to add some for tasks or something else more specific.

Links, if present, will appear in a small dropdown button in the request action buttons section:

screen shot 2017-11-17 at 7 44 22 am

ssalinas added some commits Nov 17, 2017

@ssalinas

This comment has been minimized.

Member

ssalinas commented Nov 17, 2017

@ssalinas ssalinas added this to the 0.19.0 milestone Nov 17, 2017

}
});
} catch (err) {
return undefined;

This comment has been minimized.

@kwm4385

kwm4385 Nov 17, 2017

Contributor

Is there a reason you're returning undefined rather than null?

This comment has been minimized.

@ssalinas

ssalinas Nov 17, 2017

Member

no particular reason. Is there a preference/reasoning for one over the other?

@kwm4385

This comment has been minimized.

Contributor

kwm4385 commented Nov 30, 2017

🚢

@ssalinas ssalinas added the hs_stable label Nov 30, 2017

@baconmania

This comment has been minimized.

Contributor

baconmania commented Dec 4, 2017

🚢

@ssalinas ssalinas merged commit ce5b60b into master Dec 5, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the custom_links branch Dec 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment