Skip to content

Ability to specify quick links for requests #1654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 5, 2017
Merged

Ability to specify quick links for requests #1654

merged 8 commits into from
Dec 5, 2017

Conversation

ssalinas
Copy link
Member

This adds a way that we can set custom links to other places in the infrastructure from the request detail page. The links can be templated using formats like: http://example.com?person={{request.owners.0}}. The links can be specified per request type as well. I also put a top level key of "request" in the config in case we later decide to add some for tasks or something else more specific.

Links, if present, will appear in a small dropdown button in the request action buttons section:

screen shot 2017-11-17 at 7 44 22 am

@ssalinas
Copy link
Member Author

cc @kwm4385

@ssalinas ssalinas added this to the 0.19.0 milestone Nov 17, 2017
}
});
} catch (err) {
return undefined;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you're returning undefined rather than null?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no particular reason. Is there a preference/reasoning for one over the other?

@kwm4385
Copy link
Contributor

kwm4385 commented Nov 30, 2017

🚢

@baconmania
Copy link
Contributor

🚢

@ssalinas ssalinas merged commit ce5b60b into master Dec 5, 2017
@ssalinas ssalinas deleted the custom_links branch December 5, 2017 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants