New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement getPortByIndex in SingularityTask #1663

Merged
merged 2 commits into from Dec 1, 2017

Conversation

Projects
None yet
3 participants
@ssalinas
Member

ssalinas commented Dec 1, 2017

This was removed in the removal of the mesos dep from SingularityBase. Adding it back in for convenience.

@ssalinas ssalinas added this to the 0.18.1 milestone Dec 1, 2017

@JsonIgnore // to mimic mesos
public List<MesosRangeObject> getRangesList() {
return getRange();

This comment has been minimized.

@darcatron

darcatron Dec 1, 2017

Contributor

not sure I understand the reason for this method. doesn't seem to do anything different than getRange()

@darcatron

darcatron Dec 1, 2017

Contributor

not sure I understand the reason for this method. doesn't seem to do anything different than getRange()

This comment has been minimized.

@baconmania

baconmania Dec 1, 2017

Contributor

It's to mimic the convention used by the Mesos API, with stuff like getPortsList().

@baconmania

baconmania Dec 1, 2017

Contributor

It's to mimic the convention used by the Mesos API, with stuff like getPortsList().

This comment has been minimized.

@ssalinas

ssalinas Dec 1, 2017

Member

correct, added with the aim of not breaking binary compatibility for those who were using the old mesos protos objects

@ssalinas

ssalinas Dec 1, 2017

Member

correct, added with the aim of not breaking binary compatibility for those who were using the old mesos protos objects

@baconmania

This comment has been minimized.

Show comment
Hide comment
@baconmania

baconmania Dec 1, 2017

Contributor

🚢

Contributor

baconmania commented Dec 1, 2017

🚢

@ssalinas ssalinas added the hs_stable label Dec 1, 2017

@ssalinas ssalinas merged commit 4c57015 into master Dec 1, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the port_by_index branch Dec 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment