Reimplement getPortByIndex in SingularityTask #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matush-v
reviewed
Dec 1, 2017
|
|
||
| @JsonIgnore // to mimic mesos | ||
| public List<MesosRangeObject> getRangesList() { | ||
| return getRange(); |
There was a problem hiding this comment.
not sure I understand the reason for this method. doesn't seem to do anything different than getRange()
There was a problem hiding this comment.
It's to mimic the convention used by the Mesos API, with stuff like getPortsList().
There was a problem hiding this comment.
correct, added with the aim of not breaking binary compatibility for those who were using the old mesos protos objects
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was removed in the removal of the mesos dep from SingularityBase. Adding it back in for convenience.