New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support user overrides in Run-Now requests. #1668

Merged
merged 3 commits into from Dec 4, 2017

Conversation

Projects
None yet
2 participants
@baconmania
Contributor

baconmania commented Dec 1, 2017

No description provided.

baconmania added some commits Dec 1, 2017

@baconmania

This comment has been minimized.

Contributor

baconmania commented Dec 1, 2017

Just wanted to mention that there's a subtlety in SingularityMesosTaskBuilder that might not be entirely obvious. When using our custom executor, the SingularityDeploy#user field controls which user the Mesos containerizer switches to before running the singularity-executor script, while the SingularityDeploy#executorData#user field controls which user our executor switches to before actually running the Task's configured command. Is this something we want to make clearer?

/cc @ssalinas @tpetr

@ssalinas ssalinas added this to the 0.19.0 milestone Dec 4, 2017

@baconmania baconmania assigned baconmania and unassigned baconmania Dec 4, 2017

@baconmania

This comment has been minimized.

Contributor

baconmania commented Dec 4, 2017

Tested & working for both default and custom executors.

@baconmania baconmania merged commit 097469d into run_now_overrides Dec 4, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@baconmania baconmania deleted the run-now-user-override branch Dec 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment