Remove SingularityServiceBase module, no longer needed - #1671
Merged
Conversation
baconmania
reviewed
Dec 4, 2017
|
|
||
| mesos: | ||
| master: http://[mesos master hostname]/api/v1/scheduler | ||
| master: [comma separated list of mesos master host:post] |
Contributor
|
Good to go other than the small typo there. |
Contributor
|
🚢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SingularityServiceBasewas originally split out when we were toying with the coordinator and had the possibility of two modules which could serve up the UI. Due to the fact that the way we package and access the UI internally slightly differs from our release process, we didn't catch the fact that moving this to another module messes with the static resources for the SingularityService shaded jar.This PR puts all of the SingularityServiceBase bits back into SingularityService now that the separate module is no longer needed
/fixes #1670