Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide option to prevent emails for scale events #1681

Merged
merged 4 commits into from Dec 7, 2017

Conversation

Projects
None yet
2 participants
@darcatron
Copy link
Contributor

darcatron commented Dec 6, 2017

This updates the scaleRequest object to include another optional boolean skipEmailNotification. By default, we'll send emails for scale events, but users can toggle their request to prevent email notifications.

@darcatron darcatron requested a review from ssalinas Dec 6, 2017

@ssalinas

This comment has been minimized.

Copy link
Member

ssalinas commented Dec 6, 2017

🚢

@darcatron darcatron added the hs_staging label Dec 6, 2017

@JsonProperty("message") Optional<String> message,
@JsonProperty("bounce") Optional<Boolean> bounce,
@JsonProperty("incremental") Optional<Boolean> incremental,
@JsonProperty("skipEmailNotification") Optional<Boolean> skipEmailNotification) {

This comment has been minimized.

@ssalinas

ssalinas Dec 6, 2017

Member

documenting in-person conversation here as well, we should keep the old constructor around as well so we don't break anyone's builds 👍

darcatron added some commits Dec 6, 2017

@ssalinas

This comment has been minimized.

Copy link
Member

ssalinas commented Dec 6, 2017

🚢

@ssalinas ssalinas added this to the 0.19.0 milestone Dec 6, 2017

@ssalinas ssalinas merged commit 821a394 into master Dec 7, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the no-solicitors branch Dec 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.