Provide option to prevent emails for scale events #1681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssalinas
approved these changes
Dec 6, 2017
|
|
ssalinas
reviewed
Dec 6, 2017
| @JsonProperty("message") Optional<String> message, | ||
| @JsonProperty("bounce") Optional<Boolean> bounce, | ||
| @JsonProperty("incremental") Optional<Boolean> incremental, | ||
| @JsonProperty("skipEmailNotification") Optional<Boolean> skipEmailNotification) { |
There was a problem hiding this comment.
documenting in-person conversation here as well, we should keep the old constructor around as well so we don't break anyone's builds
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This updates the scaleRequest object to include another optional boolean
skipEmailNotification. By default, we'll send emails for scale events, but users can toggle their request to prevent email notifications.