Allow a request in FINISHED state to be redeployed #1685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssalinas
changed the title
|
Changed this up and added a test for it. Instead of setting to active before the deploy, I am setting it to active after a successful deploy, and allowing FINISHED states to pass through the deploy checker. |
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should probably add some messaging in the ui about what FINISHED actually means (that a provided schedule has no more iterations).
This should cover the case of allowing a finished request to be redeployed, since there is currently no other way to update it other than to pause + deploy to unpause with a new schedule. Previously it was hitting the case in the deploy checker for
isActiveand failing every deploy at that point.This sets the state of the request back to active when the new deploy is created, which will allow it to pass the deploy checked.
Still need to add tests and determine if a deploy failure will allow it to move back to finished state correctly