New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a request in FINISHED state to be redeployed #1685

Merged
merged 3 commits into from Dec 21, 2017

Conversation

Projects
None yet
2 participants
@ssalinas
Member

ssalinas commented Dec 13, 2017

Should probably add some messaging in the ui about what FINISHED actually means (that a provided schedule has no more iterations).

This should cover the case of allowing a finished request to be redeployed, since there is currently no other way to update it other than to pause + deploy to unpause with a new schedule. Previously it was hitting the case in the deploy checker for isActive and failing every deploy at that point.

This sets the state of the request back to active when the new deploy is created, which will allow it to pass the deploy checked.

Still need to add tests and determine if a deploy failure will allow it to move back to finished state correctly

@ssalinas ssalinas changed the title from WIP - Allow a request in FINISHED state to be redeployed to Allow a request in FINISHED state to be redeployed Dec 13, 2017

@ssalinas

This comment has been minimized.

Member

ssalinas commented Dec 13, 2017

Changed this up and added a test for it. Instead of setting to active before the deploy, I am setting it to active after a successful deploy, and allowing FINISHED states to pass through the deploy checker.

@ssalinas ssalinas added this to the 0.19.0 milestone Dec 13, 2017

@pschoenfelder

This comment has been minimized.

Contributor

pschoenfelder commented Dec 15, 2017

🚢

@ssalinas ssalinas added the hs_stable label Dec 15, 2017

@ssalinas ssalinas merged commit 9f40fce into master Dec 21, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the finished_redeploy branch Dec 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment