Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAlso check pending requests on the track task endpoint #1688
Conversation
ssalinas
added
hs_staging
hs_qa
labels
Dec 20, 2017
ssalinas
added this to the 0.19.0 milestone
Dec 21, 2017
This comment has been minimized.
This comment has been minimized.
|
|
ssalinas
added
the
hs_stable
label
Dec 21, 2017
ssalinas
merged commit 5811850
into
master
Dec 22, 2017
ssalinas
deleted the
track_pending_req
branch
Dec 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ssalinas commentedDec 20, 2017
If a RunNowRequest was enqueued, but still in the pending request queue waiting to be processed by the scheduler, the track endpoint would return an absent. We should also be able to mark the task as pending when it is in the pending request queue. This adds an additional check of the pending requests