New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second pass at Mesos containers, with volume sources and network mapping #1690

Merged
merged 3 commits into from Jan 17, 2018

Conversation

Projects
None yet
2 participants
@stevenschlansker
Contributor

stevenschlansker commented Jan 4, 2018

Lightly tested with a task like:

{
  "activeDeploy": {
    "requestId": "opengrok",
    "id": "steven_2018_01_04T00_18_07",
    "command": "/opengrok-ot/run.sh",
    "containerInfo": {
      "type": "MESOS",
      "volumes": [
        {
          "containerPath": "/opengrok",
          "mode": "RW",
          "source": {
            "type": "DOCKER_VOLUME",
            "dockerVolume": {
              "driver": "rexray",
              "name": "opengrok-mesos"
            }
          }
        }
      ],
      "mesos": {
        "image": {
          "type": "DOCKER",
          "docker": {
            "name": "docker.mycorp.com/opengrok:41"
          }
        }
      }
    },
    "resources": {
      "cpus": 1,
      "memoryMb": 5192
    }
  }

cc @pennello @mikebell90 @carlf @kstdennis

@ssalinas

This comment has been minimized.

Member

ssalinas commented Jan 4, 2018

Thanks @stevenschlansker , internally we use the custom executor for most stuff, so I can’t say that it will get a ton of regular usage to find all the edge cases, but I’m happy to test the basics so we can try to get this in the next release. This week is a bit full of TODOs, but I might be able to at least try it out locally and in our staging environment

@stevenschlansker

This comment has been minimized.

Contributor

stevenschlansker commented Jan 4, 2018

We're running it in our QA environment. Since it's almost entirely allowing pass-through data from Singularity through to Mesos protobufs, it should be reasonably low risk to existing users. I don't love the API structure, but it matches Mesos closely, and I don't have a proposal for a better higher-level API at this time.

@ssalinas ssalinas added the hs_staging label Jan 10, 2018

@ssalinas ssalinas added the hs_qa label Jan 17, 2018

@ssalinas ssalinas added this to the 0.19.0 milestone Jan 17, 2018

@ssalinas ssalinas added the hs_stable label Jan 17, 2018

@ssalinas

This comment has been minimized.

Member

ssalinas commented Jan 17, 2018

🚢

@ssalinas ssalinas merged commit c3bc423 into HubSpot:master Jan 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stevenschlansker stevenschlansker deleted the stevenschlansker:volume-support branch Jan 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment