Skip to content

Conversation

@stevenschlansker
Copy link
Contributor

@stevenschlansker stevenschlansker commented Jan 4, 2018

Lightly tested with a task like:

{
  "activeDeploy": {
    "requestId": "opengrok",
    "id": "steven_2018_01_04T00_18_07",
    "command": "/opengrok-ot/run.sh",
    "containerInfo": {
      "type": "MESOS",
      "volumes": [
        {
          "containerPath": "/opengrok",
          "mode": "RW",
          "source": {
            "type": "DOCKER_VOLUME",
            "dockerVolume": {
              "driver": "rexray",
              "name": "opengrok-mesos"
            }
          }
        }
      ],
      "mesos": {
        "image": {
          "type": "DOCKER",
          "docker": {
            "name": "docker.mycorp.com/opengrok:41"
          }
        }
      }
    },
    "resources": {
      "cpus": 1,
      "memoryMb": 5192
    }
  }

cc @pennello @mikebell90 @carlf @kstdennis

@ssalinas
Copy link
Member

ssalinas commented Jan 4, 2018

Thanks @stevenschlansker , internally we use the custom executor for most stuff, so I can’t say that it will get a ton of regular usage to find all the edge cases, but I’m happy to test the basics so we can try to get this in the next release. This week is a bit full of TODOs, but I might be able to at least try it out locally and in our staging environment

@stevenschlansker
Copy link
Contributor Author

We're running it in our QA environment. Since it's almost entirely allowing pass-through data from Singularity through to Mesos protobufs, it should be reasonably low risk to existing users. I don't love the API structure, but it matches Mesos closely, and I don't have a proposal for a better higher-level API at this time.

@ssalinas
Copy link
Member

🚢

@ssalinas ssalinas merged commit c3bc423 into HubSpot:master Jan 17, 2018
@stevenschlansker stevenschlansker deleted the volume-support branch January 17, 2018 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants