Second pass at Mesos containers, with volume sources and network mapping #1690
Conversation
9b6a387
to
7a77fb0
Thanks @stevenschlansker , internally we use the custom executor for most stuff, so I can’t say that it will get a ton of regular usage to find all the edge cases, but I’m happy to test the basics so we can try to get this in the next release. This week is a bit full of TODOs, but I might be able to at least try it out locally and in our staging environment |
7a77fb0
to
f784aa2
f784aa2
to
a8a1dd4
We're running it in our QA environment. Since it's almost entirely allowing pass-through data from Singularity through to Mesos protobufs, it should be reasonably low risk to existing users. I don't love the API structure, but it matches Mesos closely, and I don't have a proposal for a better higher-level API at this time. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Lightly tested with a task like:
cc @pennello @mikebell90 @carlf @kstdennis