New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nav bar for mobile view #1696

Merged
merged 1 commit into from Jan 22, 2018

Conversation

Projects
None yet
4 participants
@benheng
Contributor

benheng commented Jan 18, 2018

No description provided.

@benheng

This comment has been minimized.

Contributor

benheng commented Jan 18, 2018

Hidden navigation with hamburger button:

screen shot 2018-01-18 at 15 41 49

Hamburger button clicked opens a vertical nav list:

screen shot 2018-01-18 at 15 42 11

@andyhuang91

This comment has been minimized.

andyhuang91 commented Jan 19, 2018

LGTM. Since we are using react-bootstrap, you could also simplify the rest of the navigation file by using those components.

@benheng benheng merged commit 9795f8f into master Jan 22, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@benheng benheng deleted the fix-mobile-nav-bar branch Jan 22, 2018

@kwm4385

This comment has been minimized.

Contributor

kwm4385 commented Jan 22, 2018

@benheng Since the release process for Singularity is a bit different, we'll need to merge and deploy this through our three environment branches in sequence. These are hs_staging, hs_qa and hs_stable. After you merge your feature branch into one of these, add the corresponding label on the PR. Let me or Andy know if you have any questions!

@benheng benheng restored the fix-mobile-nav-bar branch Jan 25, 2018

@benheng benheng deleted the fix-mobile-nav-bar branch Jan 25, 2018

@ssalinas ssalinas added this to the 0.19.0 milestone Feb 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment