Skip to content

Support uploads to GCS - #1697

Merged
ssalinas merged 10 commits into
masterfrom
gcs
Jan 26, 2018
Merged

ssalinas merged 10 commits into
masterfrom
gcs

Conversation

@ssalinas

Copy link
Copy Markdown
Contributor

WIP, still need to figure out passing credentials around in the metadata

cc @baconmania

Comment thread SingularityS3Uploader/pom.xml Outdated
<dependency>
<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-java</artifactId>
<version>3.5.1</version>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is gross, but still figuring out a clean way to do these dependencies. The latest version of google-cloud-storage also pulls in an incompatible version of google-http-client as compared to the latest version of google-auth-library-oauth2-http which is an additional pain

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baconmania or @stevegutz any thoughts on the best way to handle these weird dep issues here? Works to override protobuf here because the S3Uploader doesn't actually have to pull in org.apache.mesos, but not sure that it's the cleanest thing to do

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's pulling in the protobuf dep?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

org.apache.mesos pulls in 2.6, google-cloud-storage pulls in 3.5.1

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I'm more wondering if it's too much of a code smell to override the version for just this module when the rest of Singularity is using 2.6

@ssalinas ssalinas added this to the 0.19.0 milestone Jan 24, 2018
@ssalinas

Copy link
Copy Markdown
Contributor Author

tested and working in hs_staging

@ssalinas ssalinas added the hs_qa label Jan 24, 2018
@baconmania

Copy link
Copy Markdown
Contributor

🚢

@ssalinas
ssalinas merged commit e1a7909 into master Jan 26, 2018
@ssalinas
ssalinas deleted the gcs branch January 26, 2018 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants