New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support uploads to GCS #1697

Merged
merged 10 commits into from Jan 26, 2018

Conversation

Projects
None yet
3 participants
@ssalinas
Member

ssalinas commented Jan 19, 2018

WIP, still need to figure out passing credentials around in the metadata

cc @baconmania

ssalinas added some commits Jan 19, 2018

<dependency>
<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-java</artifactId>
<version>3.5.1</version>

This comment has been minimized.

@ssalinas

ssalinas Jan 22, 2018

Member

This is gross, but still figuring out a clean way to do these dependencies. The latest version of google-cloud-storage also pulls in an incompatible version of google-http-client as compared to the latest version of google-auth-library-oauth2-http which is an additional pain

This comment has been minimized.

@ssalinas

ssalinas Jan 24, 2018

Member

@baconmania or @stevegutz any thoughts on the best way to handle these weird dep issues here? Works to override protobuf here because the S3Uploader doesn't actually have to pull in org.apache.mesos, but not sure that it's the cleanest thing to do

This comment has been minimized.

@stevegutz

stevegutz Jan 24, 2018

Contributor

What's pulling in the protobuf dep?

This comment has been minimized.

@ssalinas

ssalinas Jan 24, 2018

Member

org.apache.mesos pulls in 2.6, google-cloud-storage pulls in 3.5.1

This comment has been minimized.

@ssalinas

ssalinas Jan 24, 2018

Member

I guess I'm more wondering if it's too much of a code smell to override the version for just this module when the rest of Singularity is using 2.6

@ssalinas ssalinas added this to the 0.19.0 milestone Jan 24, 2018

@ssalinas ssalinas added the hs_staging label Jan 24, 2018

@ssalinas

This comment has been minimized.

Member

ssalinas commented Jan 24, 2018

tested and working in hs_staging

@ssalinas ssalinas added the hs_qa label Jan 24, 2018

@baconmania

This comment has been minimized.

Contributor

baconmania commented Jan 26, 2018

🚢

@ssalinas ssalinas added the hs_stable label Jan 26, 2018

@ssalinas ssalinas merged commit e1a7909 into master Jan 26, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the gcs branch Jan 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment