Support uploads to GCS #1697
Support uploads to GCS #1697
Conversation
SingularityS3Uploader/pom.xml
Outdated
| <dependency> | ||
| <groupId>com.google.protobuf</groupId> | ||
| <artifactId>protobuf-java</artifactId> | ||
| <version>3.5.1</version> |
There was a problem hiding this comment.
This is gross, but still figuring out a clean way to do these dependencies. The latest version of google-cloud-storage also pulls in an incompatible version of google-http-client as compared to the latest version of google-auth-library-oauth2-http which is an additional pain
There was a problem hiding this comment.
@baconmania or @stevegutz any thoughts on the best way to handle these weird dep issues here? Works to override protobuf here because the S3Uploader doesn't actually have to pull in org.apache.mesos, but not sure that it's the cleanest thing to do
There was a problem hiding this comment.
What's pulling in the protobuf dep?
There was a problem hiding this comment.
org.apache.mesos pulls in 2.6, google-cloud-storage pulls in 3.5.1
There was a problem hiding this comment.
I guess I'm more wondering if it's too much of a code smell to override the version for just this module when the rest of Singularity is using 2.6
|
tested and working in hs_staging |
|
🚢 |
WIP, still need to figure out passing credentials around in the metadata
cc @baconmania