Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show s3 logs error message as a pop up #1698

Merged
merged 2 commits into from Jan 24, 2018

Conversation

Projects
None yet
2 participants
@ssalinas
Copy link
Member

ssalinas commented Jan 23, 2018

In the specific case of the S3 logs, folks have found the pop up error message to be more annoying than helpful. This updates the code to catch the 500 and avoid that pop up, replacing it with a message on the S3 Logs section itself

cc @kwm4385

ssalinas added some commits Jan 23, 2018

@ssalinas ssalinas added this to the 0.19.0 milestone Jan 24, 2018

@kwm4385

This comment has been minimized.

Copy link
Contributor

kwm4385 commented Jan 24, 2018

🚢

@ssalinas ssalinas added the hs_stable label Jan 24, 2018

@ssalinas ssalinas merged commit 66e76b5 into master Jan 24, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the s3_err_message branch Jan 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.