Better webhook auth timeouts and exception messages #1703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaylward
reviewed
Feb 5, 2018
| .refreshAfterWrite(webhookAuthConfiguration.getCacheValidationMs(), TimeUnit.MILLISECONDS) | ||
| .build(new CacheLoader<String, SingularityUserPermissionsResponse>() { | ||
| @Override | ||
| public SingularityUserPermissionsResponse load(String authHeaderVaule) throws Exception { |
Contributor
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when using multiple auth methods, if all failed singularity would only return the message from the final one attempted. Also, the AsyncHttpClient used for webhook auth calls had all of the default timeouts and retries set, which are too high to auth calls.
This PR updates the multiple auth method caller to gather exception messages from each attempted auth method and return a combined message. It also updates the webhook auth http client to user much shorter timeouts (now defaults to 2s connect, 2s request, 2 retries) which are configurable in the auth configuration