Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for configurable navbar title links. #1704
Conversation
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
Will let @kwm4385 and the more-UI-inclined take a look at the react bits, but I agree on making this and the admin dropdown match |
kwm4385
reviewed
Feb 5, 2018
Made a few changes to get everything working right and for styling. Highlights below
| @@ -35,6 +35,26 @@ function isActive(navbarPath, fragment) { | ||
| // put into page wrapper, render children | ||
| const Navigation = (props) => { | ||
| const fragment = props.location.pathname.split('/')[1]; | ||
| const navTitle = config.navTitleLinks | ||
| ? ( | ||
| <ul className="nav navbar-nav"> |
This comment has been minimized.
This comment has been minimized.
kwm4385
Feb 5, 2018
Contributor
Wrapping this in the same ul structure will give the consistent menu look you seek.
| @@ -35,6 +35,26 @@ function isActive(navbarPath, fragment) { | ||
| // put into page wrapper, render children | ||
| const Navigation = (props) => { | ||
| const fragment = props.location.pathname.split('/')[1]; | ||
| const navTitle = config.navTitleLinks |
This comment has been minimized.
This comment has been minimized.
kwm4385
Feb 5, 2018
Contributor
Needed a null check for the config field itself somewhere, otherwise it would break if it wasn't set.
| {config.title} <span className="caret" /> | ||
| </a> | ||
| <ul className="dropdown-menu"> | ||
| {Object.keys(config.navTitleLinks).map((linkTitle, index) => |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
baconmania
added
hs_staging
hs_qa
hs_stable
labels
Feb 5, 2018
This comment has been minimized.
This comment has been minimized.
|
|
ssalinas
merged commit b7cb83c
into
master
Feb 7, 2018
ssalinas
deleted the
nav-title-links
branch
Feb 7, 2018
ssalinas
added this to the 0.19.0 milestone
Feb 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
baconmania commentedFeb 2, 2018
•
edited
Looks like
This setup defaults to having the nav header title link back to the Dashboard (as is the case today) if no links are configured.
Might have to tweak the CSS class setup slightly, since the
Admindropdown has squared corners, but this one's got rounded corners.