Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take system usage into account when scoring offers #1711

Merged
merged 7 commits into from Feb 15, 2018
Merged

Take system usage into account when scoring offers #1711

merged 7 commits into from Feb 15, 2018

Conversation

@ssalinas
Copy link
Member

@ssalinas ssalinas commented Feb 14, 2018

  • Also collect system usage for mesos slaves
  • Ability to score on system vs task usage on the slave
  • fix a missing lock in drainPendingQueue
  • fix bug in grabbing slave usage by id
@ssalinas ssalinas added the hs_staging label Feb 14, 2018
ssalinas added 3 commits Feb 14, 2018
case SPREAD_SYSTEM_USAGE:
default:
double systemCpuFreeScore = Math.max(0, 1 - slaveUsage.getSystemLoad15Min());
double systemMemFreeScore = 1 - (slaveUsage.getSystemMemTotalBytes() - slaveUsage.getSystemMemTotalBytes()) / slaveUsage.getSystemMemTotalBytes();

This comment has been minimized.

@darcatron

darcatron Feb 14, 2018
Contributor

I think this should be slaveUsage.getSystemMemTotalBytes() - slaveUsage.getSystemMemFreeBytes()

This comment has been minimized.

@ssalinas

ssalinas Feb 14, 2018
Author Member

thanks, fixed

@ssalinas ssalinas added the hs_qa label Feb 15, 2018
@ssalinas ssalinas added this to the 0.19.0 milestone Feb 15, 2018
@darcatron
Copy link
Contributor

@darcatron darcatron commented Feb 15, 2018

lgtm 🚢

@ssalinas ssalinas added the hs_stable label Feb 15, 2018
@ssalinas ssalinas merged commit 500c283 into master Feb 15, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ssalinas ssalinas deleted the rebalance branch Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants