/Singularity

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take system usage into account when scoring offers #1711

Merged
merged 7 commits into from Feb 15, 2018

Conversation

Reviewers

@darcatron darcatron

Assignees
No one assigned
Labels
Projects
None yet
Milestone
  0.19.0
2 participants
@ssalinas @darcatron
@ssalinas
Member

ssalinas commented Feb 14, 2018

  • Also collect system usage for mesos slaves
  • Ability to score on system vs task usage on the slave
  • fix a missing lock in drainPendingQueue
  • fix bug in grabbing slave usage by id

@ssalinas ssalinas added the hs_staging label Feb 14, 2018

ssalinas added some commits Feb 14, 2018

@ssalinas
fix constructor for usage
Loading status checks…
926e96e
@ssalinas
fix usage poller test
Loading status checks…
9e66f27
@ssalinas
return offers after exception
Loading status checks…
e01e862
...arityService/src/main/java/com/hubspot/singularity/mesos/SingularityMesosOfferScheduler.java Outdated
case SPREAD_SYSTEM_USAGE:
default:
double systemCpuFreeScore = Math.max(0, 1 - slaveUsage.getSystemLoad15Min());
double systemMemFreeScore = 1 - (slaveUsage.getSystemMemTotalBytes() - slaveUsage.getSystemMemTotalBytes()) / slaveUsage.getSystemMemTotalBytes();

This comment has been minimized.

Sign in to view
Copy link
@darcatron

darcatron Feb 14, 2018

Contributor

I think this should be slaveUsage.getSystemMemTotalBytes() - slaveUsage.getSystemMemFreeBytes()

This comment has been minimized.

Sign in to view
Copy link
@ssalinas

ssalinas Feb 14, 2018

Member

thanks, fixed
@ssalinas
fix system mem bytes score
Loading status checks…
fa38fbe

@ssalinas ssalinas added the hs_qa label Feb 15, 2018

@ssalinas ssalinas added this to the 0.19.0 milestone Feb 15, 2018

@darcatron

This comment has been minimized.

Sign in to view
Contributor

darcatron commented Feb 15, 2018

lgtm 🚢

@ssalinas ssalinas added the hs_stable label Feb 15, 2018

@ssalinas ssalinas merged commit 500c283 into master Feb 15, 2018
1 of 2 checks passed

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the rebalance branch Feb 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment