Take system usage into account when scoring offers #1711
Merged
Conversation
Member
ssalinas
commented
Feb 14, 2018
|
...arityService/src/main/java/com/hubspot/singularity/mesos/SingularityMesosOfferScheduler.java
Outdated
| case SPREAD_SYSTEM_USAGE: | ||
| default: | ||
| double systemCpuFreeScore = Math.max(0, 1 - slaveUsage.getSystemLoad15Min()); | ||
| double systemMemFreeScore = 1 - (slaveUsage.getSystemMemTotalBytes() - slaveUsage.getSystemMemTotalBytes()) / slaveUsage.getSystemMemTotalBytes(); |
darcatron
Feb 14, 2018
Contributor
I think this should be slaveUsage.getSystemMemTotalBytes() - slaveUsage.getSystemMemFreeBytes()
I think this should be slaveUsage.getSystemMemTotalBytes() - slaveUsage.getSystemMemFreeBytes()
ssalinas
Feb 14, 2018
Author
Member
thanks, fixed
thanks, fixed
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.