Take system usage into account when scoring offers #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ssalinas
commented
Feb 14, 2018
ssalinas
commented
- Also collect system usage for mesos slaves
- Ability to score on system vs task usage on the slave
- fix a missing lock in drainPendingQueue
- fix bug in grabbing slave usage by id
darcatron
reviewed
Feb 14, 2018
| case SPREAD_SYSTEM_USAGE: | ||
| default: | ||
| double systemCpuFreeScore = Math.max(0, 1 - slaveUsage.getSystemLoad15Min()); | ||
| double systemMemFreeScore = 1 - (slaveUsage.getSystemMemTotalBytes() - slaveUsage.getSystemMemTotalBytes()) / slaveUsage.getSystemMemTotalBytes(); |
There was a problem hiding this comment.
I think this should be slaveUsage.getSystemMemTotalBytes() - slaveUsage.getSystemMemFreeBytes()
|
lgtm 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.