Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix mobile menu responsiveness #1713
Conversation
This comment has been minimized.
This comment has been minimized.
andyhuang91
commented
Feb 15, 2018
|
|
benheng
added
hs_staging
hs_qa
hs_stable
labels
Feb 15, 2018
benheng
merged commit 07a6d0f
into
master
Feb 20, 2018
benheng
deleted the
fix-mobile-nav-bar
branch
Feb 20, 2018
ssalinas
added this to the 0.19.0 milestone
Feb 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
benheng commentedFeb 15, 2018
The
navclass on thelielement was causing its height to fill the nav bar, preventing users from clicking the hamburger button. The hamburger button is only visible in views where the width is less than 768px.