Skip to content

/ Singularity

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mobile menu responsiveness #1713

Merged
merged 1 commit into from Feb 20, 2018
Merged

Fix mobile menu responsiveness #1713

merged 1 commit into from Feb 20, 2018

Conversation

@benheng
Copy link
Contributor

@benheng benheng commented Feb 15, 2018

The nav class on the li element was causing its height to fill the nav bar, preventing users from clicking the hamburger button. The hamburger button is only visible in views where the width is less than 768px.
@benheng
Fix mobile menu responsiveness
Loading status checks…
ad8fc4d
@andyhuang91
Copy link

@andyhuang91 andyhuang91 commented Feb 15, 2018

🚢
@benheng benheng merged commit 07a6d0f into master Feb 20, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@benheng benheng deleted the fix-mobile-nav-bar branch Feb 20, 2018
@ssalinas ssalinas added this to the 0.19.0 milestone Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.19.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@benheng @andyhuang91 @ssalinas