Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove expiring scale when new scale has no expiration #1716

Merged
merged 2 commits into from Feb 26, 2018
Merged

Conversation

@pschoenfelder
Copy link
Contributor

@pschoenfelder pschoenfelder commented Feb 15, 2018

No description provided.

@pschoenfelder pschoenfelder requested a review from ssalinas Feb 15, 2018
Paul Schoenfelder
@ssalinas ssalinas changed the title Update expiring scales instead of adding them Remove expiring scale when new scale has no expiration Feb 15, 2018
@ssalinas
Copy link
Member

@ssalinas ssalinas commented Feb 20, 2018

🚢

@ssalinas ssalinas added this to the 0.20.0 milestone Feb 20, 2018
@pschoenfelder
Copy link
Contributor Author

@pschoenfelder pschoenfelder commented Feb 23, 2018

Done and in prod

@ssalinas ssalinas reopened this Feb 23, 2018
@ssalinas ssalinas merged commit 239a1db into master Feb 26, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ssalinas ssalinas deleted the scale-replace branch Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.