Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for expected usage when scoring offers #1720

Merged
merged 8 commits into from Feb 26, 2018
Merged

Account for expected usage when scoring offers #1720

merged 8 commits into from Feb 26, 2018

Conversation

@ssalinas
Copy link
Member

@ssalinas ssalinas commented Feb 16, 2018

Right now it's possible for us to easily overload a fairly empty machine if we have lots of tasks to schedule. The way the score is calculated, we don't account for other tasks we may have just scheduled. This adds the reserved and last recorded max usage to factoring into scoring, updating those after each task is added to an offer host.

@ssalinas ssalinas added this to the 0.20.0 milestone Feb 20, 2018
@ssalinas ssalinas added the hs_qa label Feb 21, 2018
case LOAD_5:
default:
return slaveUsage.getSystemLoad15Min();
}

This comment has been minimized.

@baconmania

baconmania Feb 22, 2018
Contributor

Fat-finger switcheroo here

This comment has been minimized.

@ssalinas

ssalinas Feb 22, 2018
Author Member

Thanks, fixed

@baconmania
Copy link
Contributor

@baconmania baconmania commented Feb 22, 2018

🚢

@ssalinas ssalinas added the hs_stable label Feb 23, 2018
@ssalinas ssalinas merged commit 09f7982 into master Feb 26, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ssalinas ssalinas deleted the expected_usage branch Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.