Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cached offer checkin in resourceOffers #1721

Merged
merged 5 commits into from Feb 20, 2018
Merged

Fix cached offer checkin in resourceOffers #1721

merged 5 commits into from Feb 20, 2018

Conversation

@ssalinas
Copy link
Member

@ssalinas ssalinas commented Feb 17, 2018

Need to add this in a traditional for loop so we are using the original object in the cache. Otherwise, when we call checkIn, we don't actually check in the original object in the cache and it can no longer be checked out again

ssalinas added 5 commits Feb 17, 2018
@ssalinas ssalinas added this to the 0.19.0 milestone Feb 17, 2018
@ssalinas ssalinas changed the title Cached offer checkin Fix cached offer checkin in resourceOffers Feb 17, 2018
@baconmania
Copy link
Contributor

@baconmania baconmania commented Feb 20, 2018

🚢

@ssalinas ssalinas added the hs_stable label Feb 20, 2018
@ssalinas ssalinas merged commit 73fe014 into master Feb 20, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ssalinas ssalinas deleted the cached_offer_checkin branch Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants