Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix cached offer checkin in resourceOffers #1721
Conversation
ssalinas
added some commits
Feb 17, 2018
ssalinas
added this to the 0.19.0 milestone
Feb 17, 2018
ssalinas
changed the title from
Cached offer checkin
to
Fix cached offer checkin in resourceOffers
Feb 17, 2018
ssalinas
added
hs_staging
hs_qa
labels
Feb 17, 2018
This comment has been minimized.
This comment has been minimized.
|
|
ssalinas
added
the
hs_stable
label
Feb 20, 2018
ssalinas
merged commit 73fe014
into
master
Feb 20, 2018
ssalinas
deleted the
cached_offer_checkin
branch
Feb 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ssalinas commentedFeb 17, 2018
Need to add this in a traditional for loop so we are using the original object in the cache. Otherwise, when we call checkIn, we don't actually check in the original object in the cache and it can no longer be checked out again