Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't operate directly on pending tasks during statusUpdate #1726

Merged
merged 1 commit into from Feb 20, 2018

Conversation

Projects
None yet
2 participants
@ssalinas
Copy link
Member

ssalinas commented Feb 20, 2018

This was causing a race condition with the new locking setup where a pending task could be selected for offer scheduling, then deleted by statusUpdate while it was still being processed for offers. This PR updates the code to:

  • Save the pending request to the queue instead of directly calling scheduleTasks
  • Update tests that check pending tasks to call scheduler.drainPendingQueue() after calling statusUpdate

/cc @baconmania

@ssalinas ssalinas added the hs_staging label Feb 20, 2018

@baconmania

This comment has been minimized.

Copy link
Contributor

baconmania commented Feb 20, 2018

🚢

@ssalinas ssalinas merged commit c58abe8 into master Feb 20, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the status_update_pending_tasks branch Feb 20, 2018

@ssalinas ssalinas added this to the 0.19.0 milestone Feb 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.