Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upPermalink request within group #1748
Conversation
| @@ -1,5 +1,6 @@ | ||
| import React, {PropTypes, Component} from 'react'; | ||
| import { connect } from 'react-redux'; | ||
| import { LinkContainer } from 'react-router-bootstrap'; |
This comment has been minimized.
This comment has been minimized.
kwm4385
Feb 28, 2018
Contributor
What's the reasoning behind using LinkContainer over the standard react-router Link or an onclick handler?
This comment has been minimized.
This comment has been minimized.
benheng
Feb 28, 2018
Contributor
Link doesn't play nice with bootstrap components. I also wanted the URL to change when a user clicked on a request ID which is why I went with LinkContainer. Would it have been better to have an onClick handler and wrap the component using withRouter?
This comment has been minimized.
This comment has been minimized.
kwm4385
Feb 28, 2018
Contributor
If we were already using react-router-bootstrap I'd say this is the best solution, however, I'm hesitant to add another dependency for this single use case since we already have so many. For that reason I'd say go with handling it via onClick and withRouter.
| </NavItem> | ||
| <LinkContainer | ||
| eventKey={requestId} | ||
| key={index} |
This comment has been minimized.
This comment has been minimized.
| @@ -13,7 +14,7 @@ class GroupDetail extends Component { | ||
| constructor(props) { | ||
| super(props); | ||
| this.state = { | ||
| showRequestId: _.first(props.group.requestIds) | ||
| showRequestId: props.params.requestId || _.first(props.group.requestIds), |
This comment has been minimized.
This comment has been minimized.
andyhuang91
Feb 28, 2018
component state isn't needed anymore, and you can get rid of onSelect={this.handleRequestSelect} on the Nav component
ssalinas
added
the
UI
label
Mar 1, 2018
benheng
added some commits
Mar 1, 2018
benheng
added
the
hs_staging
label
Mar 2, 2018
This comment has been minimized.
This comment has been minimized.
|
|
benheng commentedFeb 28, 2018
Previously, request groups didn't support permalinks for requests within the group. It would simply select the first request and display that.
You'd have link that looked like this:
Which would contain some requests: RequestGroup1-foo1, RequestGroup1-foo2, RequestGroup1-foo3
Now you can link them directly:
The default behavior is maintained, no request ID means display the first request. Incorrect request ID will still load the selected group page, but the request data will not be displayed since there is none.