/ Singularity Public
Catch exceptions in offer scoring #1755
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
We are seeing a few instances where we are getting stuck on the
allOf(...).join(). Best guess is that async semaphore isn't completing properly for this case. This adds exception handling within each future, setting a reference to the throwable that will then be thrown back up, causing singularity to abort (as it would normally do for uncaught exceptions in scoring). This isn't a fix for the underlying bug yet, but I'm hoping this can tease out the root cause of the exception, since we are currently swallowing these exceptions