Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch exceptions in offer scoring #1755

Merged
merged 1 commit into from Mar 15, 2018
Merged

Catch exceptions in offer scoring #1755

merged 1 commit into from Mar 15, 2018

Conversation

@ssalinas
Copy link
Member

@ssalinas ssalinas commented Mar 13, 2018

We are seeing a few instances where we are getting stuck on the allOf(...).join(). Best guess is that async semaphore isn't completing properly for this case. This adds exception handling within each future, setting a reference to the throwable that will then be thrown back up, causing singularity to abort (as it would normally do for uncaught exceptions in scoring). This isn't a fix for the underlying bug yet, but I'm hoping this can tease out the root cause of the exception, since we are currently swallowing these exceptions

cc @baconmania

@pschoenfelder
Copy link
Contributor

@pschoenfelder pschoenfelder commented Mar 14, 2018

🚢

@ssalinas ssalinas added the hs_stable label Mar 14, 2018
@ssalinas ssalinas merged commit e9dccb8 into master Mar 15, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ssalinas ssalinas deleted the offer_scoring_exn branch Mar 15, 2018
@ssalinas ssalinas added this to the 0.19.2 milestone Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants