New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't count pending requests towards underprovisioning #1757

Merged
merged 2 commits into from Mar 26, 2018

Conversation

Projects
None yet
2 participants
@pschoenfelder
Contributor

pschoenfelder commented Mar 19, 2018

No description provided.

@pschoenfelder pschoenfelder requested a review from ssalinas Mar 19, 2018

@@ -195,6 +198,7 @@ public SingularityState generateState(boolean includeRequestIds) {
updatePossiblyUnderProvisionedAndOverProvisionedIds(requestWithState, numInstances, overProvisionedRequestIds, possiblyUnderProvisionedRequestIds);
}
removePendingRequestIds(possiblyUnderProvisionedRequestIds);

This comment has been minimized.

@ssalinas

ssalinas Mar 19, 2018

Member

can we give this a better name? Like filterForPendingRequests or something more descriptive like that?

Paul Schoenfelder

@ssalinas ssalinas added this to the 0.20.0 milestone Mar 19, 2018

SingularityRequest request = requestResource.getRequest(requestId, singularityUser).getRequest();
requestManager.activate(request.toBuilder().setInstances(Optional.of(0)).build(), RequestHistoryType.UPDATED, System.currentTimeMillis(), Optional.<String> absent(), Optional.<String> absent());

This comment has been minimized.

@ssalinas

ssalinas Mar 19, 2018

Member

did you confirm that this test actually fails without the filter you added? Seems odd to have it at instances of 0 (tbh I thought our validation would catch that...)

@pschoenfelder

This comment has been minimized.

Contributor

pschoenfelder commented Mar 19, 2018

@ssalinas

This comment has been minimized.

Member

ssalinas commented Mar 22, 2018

Cool, let's move this one through the environments and get it merged. 🚢

@ssalinas ssalinas modified the milestones: 0.20.0, 0.19.2 Mar 26, 2018

@ssalinas ssalinas merged commit 11804ae into master Mar 26, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the pending-request-bug branch Mar 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment