Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't count pending requests towards underprovisioning #1757

Merged
merged 2 commits into from Mar 26, 2018

Conversation

pschoenfelder
Copy link
Contributor

No description provided.

@@ -195,6 +198,7 @@ public SingularityState generateState(boolean includeRequestIds) {
updatePossiblyUnderProvisionedAndOverProvisionedIds(requestWithState, numInstances, overProvisionedRequestIds, possiblyUnderProvisionedRequestIds);
}

removePendingRequestIds(possiblyUnderProvisionedRequestIds);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we give this a better name? Like filterForPendingRequests or something more descriptive like that?

@ssalinas ssalinas added this to the 0.20.0 milestone Mar 19, 2018

SingularityRequest request = requestResource.getRequest(requestId, singularityUser).getRequest();

requestManager.activate(request.toBuilder().setInstances(Optional.of(0)).build(), RequestHistoryType.UPDATED, System.currentTimeMillis(), Optional.<String> absent(), Optional.<String> absent());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you confirm that this test actually fails without the filter you added? Seems odd to have it at instances of 0 (tbh I thought our validation would catch that...)

@pschoenfelder
Copy link
Contributor Author

pschoenfelder commented Mar 19, 2018 via email

@ssalinas
Copy link
Member

Cool, let's move this one through the environments and get it merged. 🚢

@ssalinas ssalinas modified the milestones: 0.20.0, 0.19.2 Mar 26, 2018
@ssalinas ssalinas merged commit 11804ae into master Mar 26, 2018
@ssalinas ssalinas deleted the pending-request-bug branch March 26, 2018 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants