New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove task credit ui calls, no longer used #1761

Merged
merged 2 commits into from Mar 26, 2018

Conversation

Projects
None yet
3 participants
@ssalinas
Member

ssalinas commented Mar 22, 2018

Missed a few pieces when removing this. The backend and visual components were removed, forgot the background refresh piece.

@ssalinas ssalinas added the hs_staging label Mar 22, 2018

@benheng

This comment has been minimized.

Contributor

benheng commented Mar 22, 2018

There are still references to task credits in the following files:

  • Docs/reference/api.md
  • Docs/reference/apidocs/api-disasters.md
  • Docs/reference/apidocs/models.md
  • SingularityBase/src/main/java/com/hubspot/singularity/SingularityTaskCredits.java
@ssalinas

This comment has been minimized.

Member

ssalinas commented Mar 22, 2018

the docs ones are all autogenerated and we commit them at release time. I'll remove the model from base though

@benheng

This comment has been minimized.

Contributor

benheng commented Mar 22, 2018

🚢

@ssalinas ssalinas added this to the 0.19.2 milestone Mar 26, 2018

@ssalinas ssalinas added the hs_qa label Mar 26, 2018

@benheng

This comment has been minimized.

Contributor

benheng commented Mar 26, 2018

🚢

1 similar comment
@pschoenfelder

This comment has been minimized.

Contributor

pschoenfelder commented Mar 26, 2018

🚢

@ssalinas ssalinas added the hs_stable label Mar 26, 2018

@ssalinas ssalinas merged commit 26e2aa1 into master Mar 26, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the rm_task_credits branch Mar 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment