Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove task credit ui calls, no longer used #1761

Merged
merged 2 commits into from Mar 26, 2018
Merged

Remove task credit ui calls, no longer used #1761

merged 2 commits into from Mar 26, 2018

Conversation

ssalinas
Copy link
Member

Missed a few pieces when removing this. The backend and visual components were removed, forgot the background refresh piece.

@benheng
Copy link
Contributor

benheng commented Mar 22, 2018 •
edited by ssalinas

There are still references to task credits in the following files:

  • Docs/reference/api.md
  • Docs/reference/apidocs/api-disasters.md
  • Docs/reference/apidocs/models.md
  • SingularityBase/src/main/java/com/hubspot/singularity/SingularityTaskCredits.java

@ssalinas
Copy link
Member Author

the docs ones are all autogenerated and we commit them at release time. I'll remove the model from base though

@benheng
Copy link
Contributor

benheng commented Mar 22, 2018

🚢

@ssalinas ssalinas added this to the 0.19.2 milestone Mar 26, 2018
@ssalinas ssalinas added the hs_qa label Mar 26, 2018
@benheng
Copy link
Contributor

benheng commented Mar 26, 2018

🚢

1 similar comment
@pschoenfelder
Copy link
Contributor

🚢

@ssalinas ssalinas merged commit 26e2aa1 into master Mar 26, 2018
@ssalinas ssalinas deleted the rm_task_credits branch March 26, 2018 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.19.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ssalinas @benheng @pschoenfelder