Skip to content

Remove task credit ui calls, no longer used - #1761

Merged
ssalinas merged 2 commits into
masterfrom
rm_task_credits
Mar 26, 2018
Merged

Remove task credit ui calls, no longer used#1761
ssalinas merged 2 commits into
masterfrom
rm_task_credits

Conversation

@ssalinas

Copy link
Copy Markdown
Contributor

Missed a few pieces when removing this. The backend and visual components were removed, forgot the background refresh piece.

@benheng

benheng commented Mar 22, 2018

Copy link
Copy Markdown
Contributor

There are still references to task credits in the following files:

  • Docs/reference/api.md
  • Docs/reference/apidocs/api-disasters.md
  • Docs/reference/apidocs/models.md
  • SingularityBase/src/main/java/com/hubspot/singularity/SingularityTaskCredits.java

@ssalinas

Copy link
Copy Markdown
Contributor Author

the docs ones are all autogenerated and we commit them at release time. I'll remove the model from base though

@benheng

benheng commented Mar 22, 2018

Copy link
Copy Markdown
Contributor

🚢

@ssalinas ssalinas added this to the 0.19.2 milestone Mar 26, 2018
@ssalinas ssalinas added the hs_qa label Mar 26, 2018
@benheng

benheng commented Mar 26, 2018

Copy link
Copy Markdown
Contributor

🚢

1 similar comment
@pschoenfelder

Copy link
Copy Markdown
Contributor

🚢

@ssalinas
ssalinas merged commit 26e2aa1 into master Mar 26, 2018
@ssalinas
ssalinas deleted the rm_task_credits branch March 26, 2018 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants