Support SSE S3 in SingularityUploader #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssalinas
reviewed
Mar 26, 2018
| @@ -79,7 +80,8 @@ public S3UploadMetadata(@JsonProperty("directory") String directory, | |||
| @JsonProperty("uploaderType") Optional<SingularityUploaderType> uploaderType, | |||
| @JsonProperty("gcsCredentials") Map<String, Object> gcsCredentials, | |||
| @JsonProperty("gcsStorageClass") Optional<String> gcsStorageClass, | |||
| @JsonProperty("encryptionKey") Optional<String> encryptionKey) { | |||
| @JsonProperty("encryptionKey") Optional<String> encryptionKey, | |||
| @JsonProperty("s3ServerSideEncryption") Optional<Boolean> s3ServerSideEncryption) { | |||
There was a problem hiding this comment.
Can we name this something more like useS3ServerSideEncryption? Makes it a bit more obvious it's a boolean and not a string to specify a type of encryption. Other than that PR looks good
|
|
ssalinas
reviewed
Mar 26, 2018
| @@ -217,6 +220,10 @@ public SingularityUploaderType getUploaderType() { | |||
| return encryptionKey; | |||
| } | |||
|
|
|||
| public boolean getUseS3ServerSideEncryption() { | |||
There was a problem hiding this comment.
sry, missed this earlier. Can this be isUseS3ServerSideEncryption
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This enables a flag to turn on the SSE-S3 which transparently encrypts the data on the server side and is managed by S3.
https://docs.aws.amazon.com/AmazonS3/latest/dev/UsingServerSideEncryption.html
We've tested the object metadata flag to make it indeeds sets SSE-S3 when we inspect the uploaded object on S3. This follows the S3 java-sdk documentation.
https://docs.aws.amazon.com/AmazonS3/latest/dev/SSEUsingJavaSDK.html
I am unfamiliar with the naming convention for the JSON Values so open to change it to something more suitable for our convention so far.
@baconmania @ssalinas