Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SSE S3 in SingularityUploader #1763

Merged
merged 7 commits into from Apr 2, 2018

Conversation

@leoxlin
Copy link
Member

@leoxlin leoxlin commented Mar 23, 2018

@baconmania @ssalinas

@@ -79,7 +80,8 @@ public S3UploadMetadata(@JsonProperty("directory") String directory,
@JsonProperty("uploaderType") Optional<SingularityUploaderType> uploaderType,
@JsonProperty("gcsCredentials") Map<String, Object> gcsCredentials,
@JsonProperty("gcsStorageClass") Optional<String> gcsStorageClass,
@JsonProperty("encryptionKey") Optional<String> encryptionKey) {
@JsonProperty("encryptionKey") Optional<String> encryptionKey,
@JsonProperty("s3ServerSideEncryption") Optional<Boolean> s3ServerSideEncryption) {

This comment has been minimized.

@ssalinas

ssalinas Mar 26, 2018
Member

Can we name this something more like useS3ServerSideEncryption? Makes it a bit more obvious it's a boolean and not a string to specify a type of encryption. Other than that PR looks good 👍

@ssalinas ssalinas added this to the 0.20.0 milestone Mar 26, 2018
@ssalinas
Copy link
Member

@ssalinas ssalinas commented Mar 26, 2018

🚢 I'll move this through to staging/qa/etc

@ssalinas ssalinas added the hs_staging label Mar 26, 2018
@@ -217,6 +220,10 @@ public SingularityUploaderType getUploaderType() {
return encryptionKey;
}

public boolean getUseS3ServerSideEncryption() {

This comment has been minimized.

@ssalinas

ssalinas Mar 26, 2018
Member

sry, missed this earlier. Can this be isUseS3ServerSideEncryption

ssalinas added 2 commits Mar 26, 2018
@ssalinas ssalinas added the hs_qa label Mar 27, 2018
@pschoenfelder
Copy link
Contributor

@pschoenfelder pschoenfelder commented Mar 30, 2018

🚢

@ssalinas ssalinas added the hs_stable label Mar 30, 2018
@ssalinas ssalinas merged commit f7c133f into HubSpot:master Apr 2, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@leoxlin leoxlin deleted the leoxlin:support-sse-s3-in-uploader branch Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.