New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More usage collection in parallel, less webhooks in parallel #1766

Merged
merged 4 commits into from Mar 30, 2018

Conversation

Projects
None yet
4 participants
@ssalinas
Member

ssalinas commented Mar 27, 2018

/fixes #1765

@ssalinas ssalinas added this to the 0.19.2 milestone Mar 27, 2018

@ssalinas ssalinas added the hs_staging label Mar 27, 2018

@ssalinas ssalinas added hs_qa and removed hs_qa labels Mar 27, 2018

@@ -60,23 +74,30 @@ public void checkWebhooks() {
int requestUpdates = 0;
int deployUpdates = 0;
for (SingularityWebhook webhook : webhooks) {
List<CompletableFuture<Void>> webhookFutures = new ArrayList<>();

This comment has been minimized.

@baconmania

baconmania Mar 28, 2018

Contributor

Is this list ever written to?

@Inject
public SingularityWebhookSender(SingularityConfiguration configuration, AsyncHttpClient http, ObjectMapper objectMapper, TaskHistoryHelper taskHistoryHelper, WebhookManager webhookManager) {
this.configuration = configuration;
this.http = http;
this.webhookManager = webhookManager;
this.taskHistoryHelper = taskHistoryHelper;
this.objectMapper = objectMapper;
this.webhookSemaphore = AsyncSemaphore.newBuilder(configuration::getMaxConcurrentWebhooks).build();
this.webhookExecutorService = Executors.newCachedThreadPool(new ThreadFactoryBuilder().setNameFormat("webhooks-%d").build());

This comment has been minimized.

@baconmania

baconmania Mar 28, 2018

Contributor

Doesn't look like this guy is used anywhere after being created.

@baconmania

This comment has been minimized.

Contributor

baconmania commented Mar 28, 2018

🚢

1 similar comment
@pschoenfelder

This comment has been minimized.

Contributor

pschoenfelder commented Mar 28, 2018

🚢

@ssalinas ssalinas added the hs_stable label Mar 28, 2018

@ssalinas ssalinas merged commit ba0c5f0 into master Mar 30, 2018

1 check failed

continuous-integration/travis-ci/push The Travis CI build failed
Details

@ssalinas ssalinas deleted the parallelism branch Mar 30, 2018

@stevenschlansker

This comment has been minimized.

Contributor

stevenschlansker commented Mar 30, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment