More usage collection in parallel, less webhooks in parallel #1766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baconmania
reviewed
Mar 28, 2018
| @@ -60,23 +74,30 @@ public void checkWebhooks() { | |||
| int requestUpdates = 0; | |||
| int deployUpdates = 0; | |||
|
|
|||
| for (SingularityWebhook webhook : webhooks) { | |||
| List<CompletableFuture<Void>> webhookFutures = new ArrayList<>(); | |||
There was a problem hiding this comment.
Is this list ever written to?
baconmania
reviewed
Mar 28, 2018
| @Inject | ||
| public SingularityWebhookSender(SingularityConfiguration configuration, AsyncHttpClient http, ObjectMapper objectMapper, TaskHistoryHelper taskHistoryHelper, WebhookManager webhookManager) { | ||
| this.configuration = configuration; | ||
| this.http = http; | ||
| this.webhookManager = webhookManager; | ||
| this.taskHistoryHelper = taskHistoryHelper; | ||
| this.objectMapper = objectMapper; | ||
|
|
||
| this.webhookSemaphore = AsyncSemaphore.newBuilder(configuration::getMaxConcurrentWebhooks).build(); | ||
| this.webhookExecutorService = Executors.newCachedThreadPool(new ThreadFactoryBuilder().setNameFormat("webhooks-%d").build()); |
There was a problem hiding this comment.
Doesn't look like this guy is used anywhere after being created.
|
|
1 similar comment
|
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
/fixes #1765