Skip to content

/ Singularity

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep track of offers not accounted for in SingularityOfferHolders returned by checkOffers #1768

Merged
merged 2 commits into from Mar 30, 2018
Merged

Keep track of offers not accounted for in SingularityOfferHolders returned by checkOffers #1768

merged 2 commits into from Mar 30, 2018

Conversation

@ssalinas
Copy link
Member

@ssalinas ssalinas commented Mar 27, 2018

We've occasionally seen cases where an offer remains in CHECKED_OUT state after checkOffers is run. There is a possibility that checkOffers does not return an offer holder for every offer. In this case, the cached offers still need to be returned to the cache
@ssalinas
Keep track of offers not accounted for in SingularityOfferHolders ret…
Loading status checks…
9fad1b2 
…urned by checkOffers
@ssalinas ssalinas added this to the 0.19.2 milestone Mar 27, 2018
@ssalinas ssalinas added the hs_staging label Mar 27, 2018
@ssalinas
fix removal from offer cache map
Loading status checks…
89051e3
@ssalinas ssalinas added the hs_qa label Mar 28, 2018
@pschoenfelder
Copy link
Contributor

@pschoenfelder pschoenfelder commented Mar 28, 2018

🚢
@ssalinas ssalinas added the hs_stable label Mar 28, 2018
@ssalinas ssalinas merged commit 1aa39cd into master Mar 30, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ssalinas ssalinas deleted the offer_cache_checkin branch Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.19.2
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@ssalinas @pschoenfelder