Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upKeep track of offers not accounted for in SingularityOfferHolders returned by checkOffers #1768
Conversation
ssalinas
added this to the 0.19.2 milestone
Mar 27, 2018
ssalinas
added
the
hs_staging
label
Mar 27, 2018
ssalinas
added
the
hs_qa
label
Mar 28, 2018
This comment has been minimized.
This comment has been minimized.
|
|
ssalinas
added
the
hs_stable
label
Mar 28, 2018
ssalinas
merged commit 1aa39cd
into
master
Mar 30, 2018
ssalinas
deleted the
offer_cache_checkin
branch
Mar 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
ssalinas commentedMar 27, 2018
We've occasionally seen cases where an offer remains in CHECKED_OUT state after checkOffers is run. There is a possibility that checkOffers does not return an offer holder for every offer. In this case, the cached offers still need to be returned to the cache