Skip to content

Support placeholders in webhook URIs. #1769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 1, 2018
Merged

Support placeholders in webhook URIs. #1769

merged 5 commits into from
May 1, 2018

Conversation

baconmania
Copy link
Contributor

No description provided.

@ssalinas
Copy link
Member

FYI I merged #1766 so you only have to fix the conflicts once

@ssalinas ssalinas added this to the 0.20.0 milestone Mar 30, 2018
@baconmania baconmania changed the title (WIP) Support placeholders in webhook URIs. Support placeholders in webhook URIs. Mar 30, 2018
@ssalinas
Copy link
Member

ssalinas commented Apr 3, 2018

Code looks fine, we should add a short blurb to the docs in Docs/reference/webhooks.md that this is possible though. Other than that , 👍

@ssalinas
Copy link
Member

ssalinas commented Apr 5, 2018

🚢

@ssalinas ssalinas merged commit ee552d5 into master May 1, 2018
@ssalinas ssalinas deleted the webhook-placeholders branch May 1, 2018 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.
2 participants
@baconmania @ssalinas