Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support placeholders in webhook URIs. #1769

Merged
merged 5 commits into from May 1, 2018
Merged

Support placeholders in webhook URIs. #1769

merged 5 commits into from May 1, 2018

Conversation

@baconmania
Copy link
Contributor

@baconmania baconmania commented Mar 29, 2018

No description provided.

@ssalinas
Copy link
Member

@ssalinas ssalinas commented Mar 30, 2018

FYI I merged #1766 so you only have to fix the conflicts once

@ssalinas ssalinas added this to the 0.20.0 milestone Mar 30, 2018
@baconmania baconmania changed the title (WIP) Support placeholders in webhook URIs. Support placeholders in webhook URIs. Mar 30, 2018
@ssalinas
Copy link
Member

@ssalinas ssalinas commented Apr 3, 2018

Code looks fine, we should add a short blurb to the docs in Docs/reference/webhooks.md that this is possible though. Other than that , 👍

baconmania added 2 commits Apr 3, 2018
@ssalinas
Copy link
Member

@ssalinas ssalinas commented Apr 5, 2018

🚢

@ssalinas ssalinas merged commit ee552d5 into master May 1, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ssalinas ssalinas deleted the webhook-placeholders branch May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.