Skip to content

Support placeholders in webhook URIs.#1769

Merged
ssalinas merged 5 commits into
masterfrom
webhook-placeholders
May 1, 2018
Merged

Support placeholders in webhook URIs.#1769
ssalinas merged 5 commits into
masterfrom
webhook-placeholders

Conversation

@baconmania

Copy link
Copy Markdown
Contributor

No description provided.

@ssalinas

Copy link
Copy Markdown
Contributor

FYI I merged #1766 so you only have to fix the conflicts once

@ssalinas ssalinas added this to the 0.20.0 milestone Mar 30, 2018
@baconmania baconmania changed the title (WIP) Support placeholders in webhook URIs. Support placeholders in webhook URIs. Mar 30, 2018
@ssalinas

ssalinas commented Apr 3, 2018

Copy link
Copy Markdown
Contributor

Code looks fine, we should add a short blurb to the docs in Docs/reference/webhooks.md that this is possible though. Other than that , 👍

@ssalinas

ssalinas commented Apr 5, 2018

Copy link
Copy Markdown
Contributor

🚢

@ssalinas ssalinas merged commit ee552d5 into master May 1, 2018
@ssalinas ssalinas deleted the webhook-placeholders branch May 1, 2018 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants