New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry lost tasks #1773

Merged
merged 10 commits into from May 8, 2018

Conversation

Projects
None yet
3 participants
@pschoenfelder
Contributor

pschoenfelder commented Apr 3, 2018

No description provided.

Paul Schoenfelder

@pschoenfelder pschoenfelder requested a review from ssalinas Apr 3, 2018

@ssalinas

Few comments above on the pending task piece. Would also be good to see unit tests for this. We have a good unit test framework set up already for testing interactions with status updates

Paul Schoenfelder added some commits Apr 4, 2018

Paul Schoenfelder
Paul Schoenfelder
@pschoenfelder

This comment has been minimized.

Show comment
Hide comment
@pschoenfelder

pschoenfelder Apr 5, 2018

Contributor

Where is that set of unit tests?

Contributor

pschoenfelder commented Apr 5, 2018

Where is that set of unit tests?

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Apr 9, 2018

Member

@pschoenfelder for unit test examples, you can look at anything that extends SingularitySchedulerTestBase. Those all have lots of helpers set up. You'll see the statusUpdate helper method called quite often, which you can use to test this out

Member

ssalinas commented Apr 9, 2018

@pschoenfelder for unit test examples, you can look at anything that extends SingularitySchedulerTestBase. Those all have lots of helpers set up. You'll see the statusUpdate helper method called quite often, which you can use to test this out

@ssalinas ssalinas added this to the 0.20.0 milestone Apr 11, 2018

Paul Schoenfelder

Paul Schoenfelder added some commits Apr 24, 2018

Paul Schoenfelder
Paul Schoenfelder
Paul Schoenfelder

baconmania and others added some commits Apr 27, 2018

Paul Schoenfelder
Paul Schoenfelder
@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas May 3, 2018

Member

🚢

Member

ssalinas commented May 3, 2018

🚢

@ssalinas ssalinas merged commit b2ae702 into master May 8, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the retry-lost-tasks branch May 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment