Configurably omit offers from hosts that are overloaded #1776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baconmania
reviewed
Apr 4, 2018
| @JsonIgnore | ||
| public boolean isOverloaded() { | ||
| // Any host where load5 is > 1 is overloaded. Also consider a higher threshold for load1 to take into account spikes large enough to be disruptive | ||
| return systemLoad5Min > 1.0 || systemLoad1Min > 1.5; |
There was a problem hiding this comment.
Do we want to make these values tunable knobs as well?
There was a problem hiding this comment.
yeah was going back and forth on that. Might as well for flexibility. I'll update 👍
|
🚢 |
|
🚢 |
baconmania
reviewed
Apr 5, 2018
| @@ -353,6 +355,11 @@ private double score(SingularityOfferHolder offerHolder, Map<String, Integer> ta | |||
| return 0; | |||
| } | |||
|
|
|||
| if (mesosConfiguration.isOmitOverloadedHosts() && maybeSlaveUsage.isPresent() && maybeSlaveUsage.get().isOverloaded()) { | |||
| LOG.debug("Slave {} is overloaded (), ignoring offer"); | |||
There was a problem hiding this comment.
Looks like we missed the interp'd parameters here.
There was a problem hiding this comment.
Fixed in future PR already, since this is already 🚢 ed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If, according to the metrics collected from the slave metrics endpoint, a slave is overloaded, omit these offers from scoring and do not schedule tasks there. This feature is configurable via
omitOverloadedHostsunder themesosconfig, and defaults tofalse/offOverloaded is currently defined as a load5 > 1.0 to catch ongoing load, or a load1 > 1.5 to catch shorter spikes large enough to be disruptive to tasks on the host.