Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send email on failing replacement tasks. #1785

Merged
merged 9 commits into from May 1, 2018

Conversation

@baconmania
Copy link
Contributor

@baconmania baconmania commented Apr 19, 2018

/cc @ssalinas

this.configuration = configuration;
this.requestManager = requestManager;
this.taskManager = taskManager;
this.lbClient = lbClient;
this.abort = abort;

this.taskIdToCheck = Maps.newConcurrentMap();
this.requestIdToUnhealthyCount = Maps.newConcurrentMap();

This comment has been minimized.

@ssalinas

ssalinas Apr 19, 2018
Member

documenting from in-person conversation. Right now this would reset when singularity deploys. It would be good to persist these counts somewhere

@ssalinas ssalinas added this to the 0.20.0 milestone Apr 19, 2018
@ssalinas
Copy link
Member

@ssalinas ssalinas commented Apr 25, 2018

🚢

baconmania added 2 commits Apr 26, 2018
@ssalinas
Copy link
Member

@ssalinas ssalinas commented Apr 26, 2018

🚢

@ssalinas ssalinas merged commit cca4793 into master May 1, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ssalinas ssalinas deleted the send-email-on-failing-replacement-tasks branch May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.