Add ability to set attributes that mark slave for only preemptible tasks#1788
Merged
Conversation
baconmania
reviewed
Apr 24, 2018
| return 0; | ||
| } | ||
|
|
||
| private boolean isPreemtableTask(SingularityTaskRequest taskRequest) { |
ssalinas
changed the title
Contributor
Author
|
tested and working as intended on staging 😃 |
Contributor
|
🚢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example, set:
And only long-running (worker/service) or shorter non-long-running (
avgRunTime<preemptibleTaskMaxExpectedRuntimeMs) will be placed on those slaves. As a result they are easier to shut down and replace if a portion of the mesos cluster is rotated out frequently