Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set attributes that mark slave for only preemptible tasks #1788

Merged
merged 4 commits into from
May 3, 2018

Conversation

ssalinas
Copy link
Member

For example, set:

preemptibleTasksOnlyMachineAttributes:
  preemptibleOnly: "true"

And only long-running (worker/service) or shorter non-long-running (avgRunTime < preemptibleTaskMaxExpectedRuntimeMs) will be placed on those slaves. As a result they are easier to shut down and replace if a portion of the mesos cluster is rotated out frequently

@ssalinas ssalinas added this to the 0.20.0 milestone Apr 24, 2018
@@ -387,6 +386,19 @@ private double score(SingularityOfferHolder offerHolder, Map<String, Integer> ta
return 0;
}

private boolean isPreemtableTask(SingularityTaskRequest taskRequest) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo

@ssalinas ssalinas changed the title Add ability to set attributes that mark slave for only preemtible tasks Add ability to set attributes that mark slave for only preemptible tasks Apr 24, 2018
@ssalinas ssalinas added the hs_qa label Apr 24, 2018
@ssalinas
Copy link
Member Author

tested and working as intended on staging 😃

@pschoenfelder
Copy link
Contributor

🚢

@ssalinas ssalinas merged commit 7e86a1e into master May 3, 2018
@ssalinas ssalinas deleted the preemptable_task_attr branch May 3, 2018 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants