Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI message for incremental deploy counts #1797

Merged
merged 2 commits into from
May 18, 2018
Merged

Conversation

ssalinas
Copy link
Member

No description provided.

@@ -38,7 +38,10 @@ const RequestAlerts = ({requestId, requestAPI, bounces, activeTasksForRequest, d
const { pendingDeploy, activeDeploy } = requestParent;
if (pendingDeploy) {
const deployingInstanceCount = Utils.request.deployingInstanceCount(requestParent, activeTasksForRequest.data);
const { instances } = requestParent.request;
let instances = equestParent.request.instances;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requestParent?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, thanks, hadn't actually gotten a chance to test this one yesterday

@pschoenfelder
Copy link
Contributor

🚢

@ssalinas ssalinas added this to the 0.20.0 milestone May 18, 2018
@ssalinas ssalinas merged commit 881596c into master May 18, 2018
@ssalinas ssalinas deleted the incremental_deploy_count branch May 18, 2018 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants