Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UI message for incremental deploy counts #1797

Merged
merged 2 commits into from May 18, 2018
Merged

Conversation

@ssalinas
Copy link
Member

@ssalinas ssalinas commented May 10, 2018

No description provided.

@@ -38,7 +38,10 @@ const RequestAlerts = ({requestId, requestAPI, bounces, activeTasksForRequest, d
const { pendingDeploy, activeDeploy } = requestParent;
if (pendingDeploy) {
const deployingInstanceCount = Utils.request.deployingInstanceCount(requestParent, activeTasksForRequest.data);
const { instances } = requestParent.request;
let instances = equestParent.request.instances;

This comment has been minimized.

@PtrTeixeira

PtrTeixeira May 11, 2018
Contributor

requestParent?

This comment has been minimized.

@ssalinas

ssalinas May 11, 2018
Author Member

yep, thanks, hadn't actually gotten a chance to test this one yesterday

@pschoenfelder
Copy link
Contributor

@pschoenfelder pschoenfelder commented May 14, 2018

🚢

@ssalinas ssalinas added the hs_stable label May 14, 2018
@ssalinas ssalinas added this to the 0.20.0 milestone May 18, 2018
@ssalinas ssalinas merged commit 881596c into master May 18, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ssalinas ssalinas deleted the incremental_deploy_count branch May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.