New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deep link page number to task history page. #1801

Merged
merged 5 commits into from Aug 13, 2018

Conversation

Projects
None yet
3 participants
@Tamba32
Contributor

Tamba32 commented May 18, 2018

No description provided.

@Tamba32 Tamba32 requested a review from andyhuang91 May 18, 2018

@andyhuang91

This comment has been minimized.

Show comment
Hide comment
@andyhuang91

andyhuang91 May 31, 2018

It looks like this doesn't automatically update the query param when the user clicks through the pagination buttons. We should add that so that these links become discoverable.

andyhuang91 commented May 31, 2018

It looks like this doesn't automatically update the query param when the user clicks through the pagination buttons. We should add that so that these links become discoverable.

tamba
Add initialPageNumber as default to UITable. Remove if statement in T…
…askHistoryTable's componentDidMount now that RequestDetailPage now passes the component a default initialPageNumber. Pass router.replace a location object in onPageChage prop for TaskHistoryTable.
@andyhuang91

Looks like there's a merge conflict now. Aside from that, LGTM

@ssalinas ssalinas added this to the 0.21.0 milestone Jul 9, 2018

@Tamba32 Tamba32 merged commit 9003962 into master Aug 13, 2018

0 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Aug 13, 2018

Member

🚢

Member

ssalinas commented Aug 13, 2018

🚢

@ssalinas ssalinas deleted the deep-link-task-history branch Aug 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment