New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task cleanup fixes for decommission and delete #1810

Merged
merged 5 commits into from Jul 9, 2018

Conversation

Projects
None yet
2 participants
@ssalinas
Member

ssalinas commented Jun 14, 2018

  • Requests in deleting can get stuck if a task was already bouncing, fix that by allowing the deleting cleanup to overwrite a previous one
  • If a slave is decommissioned at the same time as a deploy is happening, a new task from the new deploy can be left in a cleaning state. The pending request was always being made against the active deploy. It will now be made against the deploy for the particular task being cleaned

ssalinas added some commits Jun 15, 2018

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Jun 15, 2018

Member

Changed the deploy/decom case fix to add a pending request at the end of the deploy if it succeeds and there are any tasks in cleaning. Mucking with tasks during the deploy had other consequences.

@baconmania

Member

ssalinas commented Jun 15, 2018

Changed the deploy/decom case fix to add a pending request at the end of the deploy if it succeeds and there are any tasks in cleaning. Mucking with tasks during the deploy had other consequences.

@baconmania

@baconmania

This comment has been minimized.

Show comment
Hide comment
@baconmania

baconmania Jun 19, 2018

Contributor

🚢

Contributor

baconmania commented Jun 19, 2018

🚢

@ssalinas ssalinas added the hs_stable label Jun 19, 2018

@ssalinas ssalinas added this to the 0.21.0 milestone Jul 9, 2018

@ssalinas ssalinas merged commit 6eb32f3 into master Jul 9, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the decom_missing_pending_req branch Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment