Task cleanup fixes for decommission and delete - #1810
Merged
Conversation
ssalinas
commented
Jun 14, 2018
ssalinas
commented
Contributor
- Requests in deleting can get stuck if a task was already bouncing, fix that by allowing the deleting cleanup to overwrite a previous one
- If a slave is decommissioned at the same time as a deploy is happening, a new task from the new deploy can be left in a cleaning state. The pending request was always being made against the active deploy. It will now be made against the deploy for the particular task being cleaned
Contributor
Author
|
Changed the deploy/decom case fix to add a pending request at the end of the deploy if it succeeds and there are any tasks in cleaning. Mucking with tasks during the deploy had other consequences. |
Contributor
|
🚢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.